[PR #17] [MERGED] added tests and fixed small bug for error reply case #21

Closed
opened 2026-03-15 16:05:39 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fortio/dnsping/pull/17
Author: @ldemailly
Created: 1/21/2023
Status: Merged
Merged: 1/21/2023
Merged by: @ldemailly

Base: mainHead: tests


📝 Commits (3)

  • 2aae853 added tests and fixed small bug for error reply case
  • 4a52db7 add -x to pkill to make it work on linux
  • f43b7c9 add coverage badge

📊 Changes

7 files changed (+128 additions, -1 deletions)

View changed files

.github/workflows/codecov.yml (+21 -0)
📝 README.md (+1 -1)
📝 dnsping.go (+1 -0)
dnsping.txtar (+81 -0)
dnsping_test.go (+18 -0)
📝 go.mod (+2 -0)
📝 go.sum (+4 -0)

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fortio/dnsping/pull/17 **Author:** [@ldemailly](https://github.com/ldemailly) **Created:** 1/21/2023 **Status:** ✅ Merged **Merged:** 1/21/2023 **Merged by:** [@ldemailly](https://github.com/ldemailly) **Base:** `main` ← **Head:** `tests` --- ### 📝 Commits (3) - [`2aae853`](https://github.com/fortio/dnsping/commit/2aae853f3ed7f061bd8b68190d572a384afce8e5) added tests and fixed small bug for error reply case - [`4a52db7`](https://github.com/fortio/dnsping/commit/4a52db77b96400aaa869c8fce0be2d402ec77e3e) add -x to pkill to make it work on linux - [`f43b7c9`](https://github.com/fortio/dnsping/commit/f43b7c9b06eee308be94f5ad7f127f180d9b9fac) add coverage badge ### 📊 Changes **7 files changed** (+128 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/codecov.yml` (+21 -0) 📝 `README.md` (+1 -1) 📝 `dnsping.go` (+1 -0) ➕ `dnsping.txtar` (+81 -0) ➕ `dnsping_test.go` (+18 -0) 📝 `go.mod` (+2 -0) 📝 `go.sum` (+4 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem closed this issue 2026-03-15 16:05:49 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/dnsping#21
No description provided.