[PR #157] [MERGED] Preallocate to please linter #155

New issue

Closed

opened 2026-03-15 16:13:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-15 16:13:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fortio/dnsping/pull/157
Author: @ldemailly
Created: 1/17/2026
Status: ✅ Merged
Merged: 1/17/2026
Merged by: @ldemailly

Base: main ← Head: new_lint

📝 Commits (1)

b157a87 Preallocate to please linter

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 dnsping.go (+1 -1)

📄 Description

Avoids (new in 2.8.0)

$ golangci-lint run
dnsping.go:81:3: Consider preallocating keys (prealloc)
                keys := []string{}
                ^
1 issues:
* prealloc: 1

will fix #156 build once merged and rebased

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fortio/dnsping/pull/157 **Author:** [@ldemailly](https://github.com/ldemailly) **Created:** 1/17/2026 **Status:** ✅ Merged **Merged:** 1/17/2026 **Merged by:** [@ldemailly](https://github.com/ldemailly) **Base:** `main` ← **Head:** `new_lint` --- ### 📝 Commits (1) - [`b157a87`](https://github.com/fortio/dnsping/commit/b157a8716ca7e75c707bcdfdb313ab5590d4f373) Preallocate to please linter ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `dnsping.go` (+1 -1) </details> ### 📄 Description Avoids (new in 2.8.0) ``` $ golangci-lint run dnsping.go:81:3: Consider preallocating keys (prealloc) keys := []string{} ^ 1 issues: * prealloc: 1 ``` will fix #156 build once merged and rebased --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>