mirror of
https://github.com/mageddo/dns-proxy-server.git
synced 2026-04-25 17:35:54 +03:00
[GH-ISSUE #218] Container-name lookup results are case-sensitive. #89
Labels
No labels
bug
confirmed
discussion
duplicate
enhancement
feature
feature-request
not-planned
pull-request
secondary-feature
stale
triage
waiting-feedback
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/dns-proxy-server-mageddo#89
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ulidtko on GitHub (Mar 31, 2021).
Original GitHub issue: https://github.com/mageddo/dns-proxy-server/issues/218
Hi!
It turns out, some programs (including Postman) will garble hostnames by force-lowercasing them before querying. I'm not ready to start judging if they're right or wrong in doing that; just RFC 4343 alone tryies to clarify the whole "case-insensitivity in DNS" topic.
The fact is, DPS chokes on that. For repro, run with
MG_REGISTER_CONTAINER_NAMES=1and:To the poor Postman, this manifests as
ENOTFOUNDfromgetaddrinfo("foobar.docker")with no way to workaround:Regardless of the perhaps-broken client (which simply exposes the issue) — I believe, the DNS server portion of DPS is expected to make comparisons case-insensitively against its internal name db. Quoting from the original 1987 DNS RFC:
DPS version:
2.19.0@mageddo commented on GitHub (Mar 2, 2023):
Hey, yes, it's a DPS bug, I'm following RFC 1035 which says:
The fix must be simple though
@mageddo commented on GitHub (Mar 2, 2023):
Yeah, it's not recommended by the RFC to Postman do that, anyway I will work on DPS to be compliance with the RFC .
@mageddo commented on GitHub (Mar 3, 2023):
Fixed on #332, will be release as 3.5.3, CD will release this version package as soon as Github Actions goes back
@ulidtko commented on GitHub (Mar 6, 2023):
Thanks!
пт, 3 бер. 2023, 02:00 користувач Elvis Souza @.***>
пише: