mirror of
https://github.com/mageddo/dns-proxy-server.git
synced 2026-04-25 09:25:56 +03:00
[GH-ISSUE #183] Resolving host IP address without DPS network #73
Labels
No labels
bug
confirmed
discussion
duplicate
enhancement
feature
feature-request
not-planned
pull-request
secondary-feature
stale
triage
waiting-feedback
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/dns-proxy-server-mageddo#73
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mrubli on GitHub (Jan 7, 2020).
Original GitHub issue: https://github.com/mageddo/dns-proxy-server/issues/183
This is part question, part feature request, and part offer to help. 😉
It appears that
host.dockeralways resolves to the DPS container's IP address instead of the host machine IP unless the DPS network is enabled. I've observed this on two systems and glancing at the code seems to confirm my suspicion because the gateway IP address is only obtained if the DPS network is active.Maybe there are some scenarios I'm not thinking of right now but falling back to e.g. the
bridgenetwork and obtaining its gateway should give an IP address that's routable from most Docker networks. If this is not true for the general case perhaps a "try harder to find the host IP address" or "use network X's gateway as the host IP address" a command line switch would be useful, so that users can enable it in cases where it does work.Any thoughts? I'd be happy to help out with the implementation if this sounds useful. (It certainly would be for me cause that's pretty much the only thing missing right now in my personal use cases.)
@mageddo commented on GitHub (Jan 9, 2020):
Confirmed, there's a bug
I think it makes sense
Yep, it can be used as fallback if bridge network don't exists for some reason, I'm getting the first network listed
I've implemented these behaviors
@mageddo commented on GitHub (Jan 9, 2020):
Fixed, please make a mention if you have some issue.
Regards
@mrubli commented on GitHub (Jan 9, 2020):
After some initial testing everything looks great and works as expected. Thanks a lot for implementing that so soon! 👍