mirror of
https://github.com/mageddo/dns-proxy-server.git
synced 2026-04-25 09:25:56 +03:00
[PR #599] [MERGED] Fixing container inspect error #613
Labels
No labels
bug
confirmed
discussion
duplicate
enhancement
feature
feature-request
not-planned
pull-request
secondary-feature
stale
triage
waiting-feedback
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/dns-proxy-server-mageddo#613
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/mageddo/dns-proxy-server/pull/599
Author: @defung
Created: 11/7/2024
Status: ✅ Merged
Merged: 11/18/2024
Merged by: @mageddo
Base:
develop← Head:fix_inspect_error📝 Commits (2)
2da2c46fix inspect error98f47e4bump docker-java version📊 Changes
7 files changed (+208 additions, -10 deletions)
View changed files
📝
build.gradle(+2 -2)📝
src/main/java/com/mageddo/dnsproxyserver/docker/dataprovider/ContainerFacade.java(+2 -1)📝
src/main/java/com/mageddo/dnsproxyserver/docker/dataprovider/ContainerFacadeDefault.java(+12 -2)📝
src/main/java/com/mageddo/dnsproxyserver/solver/docker/dataprovider/ContainerDAODefault.java(+1 -1)📝
src/main/java/com/mageddo/dnsproxyserver/solver/docker/dataprovider/DpsContainerDAODefault.java(+1 -1)➕
src/test/java/com/mageddo/dnsproxyserver/docker/ContainerFacadeDefaultTest.java(+152 -0)📝
src/test/java/testing/mocks/DockerClientStub.java(+38 -3)📄 Description
Been playing around with DPS recently, and came across a bug in
docker-java(here).If a container is configured with
CAP_ADDorCAP_DROPin lowercase, DPS fails with a nasty exception (seen below).While waiting for
docker-javato fix this bug, I figured it would be good if we add some defensive coding here on this side, so it won't fail all DNS lookups if there's a single bad container.Let me know what you think!
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.