[PR #589] [MERGED] Solver Remote Refactoring #605

Closed
opened 2026-02-26 04:35:45 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/mageddo/dns-proxy-server/pull/589
Author: @mageddo
Created: 10/21/2024
Status: Merged
Merged: 10/21/2024
Merged by: @mageddo

Base: masterHead: feat/533-solver-remote-refactoring


📝 Commits (9)

📊 Changes

21 files changed (+387 additions, -309 deletions)

View changed files

📝 RELEASE-NOTES.md (+3 -0)
📝 gradle.properties (+1 -1)
📝 src/main/java/com/mageddo/commons/circuitbreaker/CircuitCheckException.java (+4 -0)
📝 src/main/java/com/mageddo/dnsproxyserver/solver/SolverRemote.java (+5 -88)
📝 src/main/java/com/mageddo/dnsproxyserver/solver/remote/Request.java (+4 -0)
📝 src/main/java/com/mageddo/dnsproxyserver/solver/remote/application/CircuitBreakerService.java (+6 -6)
src/main/java/com/mageddo/dnsproxyserver/solver/remote/application/RemoteResultSupplier.java (+63 -0)
src/main/java/com/mageddo/dnsproxyserver/solver/remote/application/ResultSupplier.java (+10 -0)
📝 src/main/java/com/mageddo/dnsproxyserver/solver/remote/application/failsafe/CircuitBreakerFactory.java (+14 -9)
📝 src/main/java/com/mageddo/dnsproxyserver/solver/remote/application/failsafe/CircuitBreakerPingCheckerService.java (+2 -2)
src/main/java/com/mageddo/dnsproxyserver/solver/remote/application/mapper/ResultMapper.java (+87 -0)
src/main/java/com/mageddo/dnsproxyserver/solver/remote/circuitbreaker/application/CircuitBreakerExecutorService.java (+0 -33)
📝 src/main/java/com/mageddo/dnsproxyserver/solver/remote/mapper/ResolverMapper.java (+5 -2)
📝 src/main/java/com/mageddo/net/IpAddr.java (+2 -0)
📝 src/test/java/com/mageddo/dnsproxyserver/solver/SolverRemoteTest.java (+0 -161)
src/test/java/com/mageddo/dnsproxyserver/solver/remote/application/RemoteResultSupplierTest.java (+68 -0)
📝 src/test/java/com/mageddo/dnsproxyserver/solver/remote/application/failsafe/CircuitBreakerFactoryTest.java (+6 -6)
src/test/java/com/mageddo/dnsproxyserver/solver/remote/application/mapper/ResultMapperTest.java (+88 -0)
📝 src/test/java/testing/templates/InetSocketAddressTemplates.java (+9 -0)
📝 src/test/java/testing/templates/MessageTemplates.java (+7 -0)

...and 1 more files

📄 Description

Relates to #533

To make the remote dns server address clear at the logs when getting timeout, I've refactor SolverRemote into two more classes separating the responsabilities


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mageddo/dns-proxy-server/pull/589 **Author:** [@mageddo](https://github.com/mageddo) **Created:** 10/21/2024 **Status:** ✅ Merged **Merged:** 10/21/2024 **Merged by:** [@mageddo](https://github.com/mageddo) **Base:** `master` ← **Head:** `feat/533-solver-remote-refactoring` --- ### 📝 Commits (9) - [`123e868`](https://github.com/mageddo/dns-proxy-server/commit/123e868025ba5c167e0bd9233ca4f94f01d6461d) refactoring solver remote class - [`cd3aac0`](https://github.com/mageddo/dns-proxy-server/commit/cd3aac0b8d1c8bb3c825e9d0d32402fc7afbd060) fixing compiling errors - [`f3b922e`](https://github.com/mageddo/dns-proxy-server/commit/f3b922e66bc82d67b50b9807608e56ac2ce0b4c5) fixing compiling errors - [`5b55859`](https://github.com/mageddo/dns-proxy-server/commit/5b5585930d8c2b46b1556840b9a4faa414d21b7b) reverting - [`95fe342`](https://github.com/mageddo/dns-proxy-server/commit/95fe342053577a5f248d0d70fdd6f85200913d44) fixing compiling errors - [`fb7b25d`](https://github.com/mageddo/dns-proxy-server/commit/fb7b25dc95dd89d39044e3ca5a81005ad49464dd) fixing compiling errors - [`eeff8d9`](https://github.com/mageddo/dns-proxy-server/commit/eeff8d915b325f2ad84283f044d5cce7e867cbfd) release notes - [`1fd462f`](https://github.com/mageddo/dns-proxy-server/commit/1fd462f6d5e82611560519ea494b9e23a25f9fdc) [Gradle Release Plugin] - new version commit: '3.30.3-snapshot'. - [`467a4e7`](https://github.com/mageddo/dns-proxy-server/commit/467a4e799d4d345d86fc8227194d30adaf3daec9) refactoring ### 📊 Changes **21 files changed** (+387 additions, -309 deletions) <details> <summary>View changed files</summary> 📝 `RELEASE-NOTES.md` (+3 -0) 📝 `gradle.properties` (+1 -1) 📝 `src/main/java/com/mageddo/commons/circuitbreaker/CircuitCheckException.java` (+4 -0) 📝 `src/main/java/com/mageddo/dnsproxyserver/solver/SolverRemote.java` (+5 -88) 📝 `src/main/java/com/mageddo/dnsproxyserver/solver/remote/Request.java` (+4 -0) 📝 `src/main/java/com/mageddo/dnsproxyserver/solver/remote/application/CircuitBreakerService.java` (+6 -6) ➕ `src/main/java/com/mageddo/dnsproxyserver/solver/remote/application/RemoteResultSupplier.java` (+63 -0) ➕ `src/main/java/com/mageddo/dnsproxyserver/solver/remote/application/ResultSupplier.java` (+10 -0) 📝 `src/main/java/com/mageddo/dnsproxyserver/solver/remote/application/failsafe/CircuitBreakerFactory.java` (+14 -9) 📝 `src/main/java/com/mageddo/dnsproxyserver/solver/remote/application/failsafe/CircuitBreakerPingCheckerService.java` (+2 -2) ➕ `src/main/java/com/mageddo/dnsproxyserver/solver/remote/application/mapper/ResultMapper.java` (+87 -0) ➖ `src/main/java/com/mageddo/dnsproxyserver/solver/remote/circuitbreaker/application/CircuitBreakerExecutorService.java` (+0 -33) 📝 `src/main/java/com/mageddo/dnsproxyserver/solver/remote/mapper/ResolverMapper.java` (+5 -2) 📝 `src/main/java/com/mageddo/net/IpAddr.java` (+2 -0) 📝 `src/test/java/com/mageddo/dnsproxyserver/solver/SolverRemoteTest.java` (+0 -161) ➕ `src/test/java/com/mageddo/dnsproxyserver/solver/remote/application/RemoteResultSupplierTest.java` (+68 -0) 📝 `src/test/java/com/mageddo/dnsproxyserver/solver/remote/application/failsafe/CircuitBreakerFactoryTest.java` (+6 -6) ➕ `src/test/java/com/mageddo/dnsproxyserver/solver/remote/application/mapper/ResultMapperTest.java` (+88 -0) 📝 `src/test/java/testing/templates/InetSocketAddressTemplates.java` (+9 -0) 📝 `src/test/java/testing/templates/MessageTemplates.java` (+7 -0) _...and 1 more files_ </details> ### 📄 Description Relates to #533 To make the remote dns server address clear at the logs when getting timeout, I've refactor SolverRemote into two more classes separating the responsabilities --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 04:35:45 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/dns-proxy-server-mageddo#605
No description provided.