[PR #585] [MERGED] Detect which condition didn't match and log the cause when configuring DPS as default DNS #603

New issue

Closed

opened 2026-02-26 04:35:44 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 04:35:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mageddo/dns-proxy-server/pull/585
Author: @mageddo
Created: 10/7/2024
Status: ✅ Merged
Merged: 10/7/2024
Merged by: @mageddo

Base: master ← Head: 580

📝 Commits (4)

250d990 adjusting dev
49fa9e8 refactoring file edition conditions to rule pattern this way I can detect which condition didn't match and log the cause
cc8e57d [Gradle Release Plugin] - new version commit: '3.30.2-snapshot'.
ce3120e release notes

📊 Changes

7 files changed (+72 additions, -16 deletions)

View changed files

📝 RELEASE-NOTES.md (+4 -0)
📝 docker-compose-dev.yml (+4 -3)
📝 gradle.properties (+1 -1)
📝 src/main/java/com/mageddo/dnsproxyserver/dnsconfigurator/linux/DnsConfiguratorLinux.java (+26 -12)
➕ src/main/java/com/mageddo/io/path/predicate/PathExistsPredicate.java (+12 -0)
➕ src/main/java/com/mageddo/io/path/predicate/PathIsFilePredicate.java (+12 -0)
➕ src/main/java/com/mageddo/io/path/predicate/PathIsWritablePredicate.java (+13 -0)

📄 Description

Refactoring file edition conditions to rule pattern this way I can detect which condition didn't match and log the cause

Relates to #580 , #578

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mageddo/dns-proxy-server/pull/585 **Author:** [@mageddo](https://github.com/mageddo) **Created:** 10/7/2024 **Status:** ✅ Merged **Merged:** 10/7/2024 **Merged by:** [@mageddo](https://github.com/mageddo) **Base:** `master` ← **Head:** `580` --- ### 📝 Commits (4) - [`250d990`](https://github.com/mageddo/dns-proxy-server/commit/250d99025c76f9206987b0ce1017ebc1600c59a3) adjusting dev - [`49fa9e8`](https://github.com/mageddo/dns-proxy-server/commit/49fa9e86d019ee83c026c343ef0d2b19f6d38fbf) refactoring file edition conditions to rule pattern this way I can detect which condition didn't match and log the cause - [`cc8e57d`](https://github.com/mageddo/dns-proxy-server/commit/cc8e57d6626b5bd2ace64071df5200f72bf3ca0e) [Gradle Release Plugin] - new version commit: '3.30.2-snapshot'. - [`ce3120e`](https://github.com/mageddo/dns-proxy-server/commit/ce3120e51dedef5a8c57f494af286c779d345c98) release notes ### 📊 Changes **7 files changed** (+72 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `RELEASE-NOTES.md` (+4 -0) 📝 `docker-compose-dev.yml` (+4 -3) 📝 `gradle.properties` (+1 -1) 📝 `src/main/java/com/mageddo/dnsproxyserver/dnsconfigurator/linux/DnsConfiguratorLinux.java` (+26 -12) ➕ `src/main/java/com/mageddo/io/path/predicate/PathExistsPredicate.java` (+12 -0) ➕ `src/main/java/com/mageddo/io/path/predicate/PathIsFilePredicate.java` (+12 -0) ➕ `src/main/java/com/mageddo/io/path/predicate/PathIsWritablePredicate.java` (+13 -0) </details> ### 📄 Description Refactoring file edition conditions to rule pattern this way I can detect which condition didn't match and log the cause Relates to #580 , #578 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>