[PR #514] [MERGED] #513 Refactoring on ConfigJson Module #549

New issue

Closed

opened 2026-02-26 04:35:36 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 04:35:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mageddo/dns-proxy-server/pull/514
Author: @mageddo
Created: 7/16/2024
Status: ✅ Merged
Merged: 7/16/2024
Merged by: @mageddo

Base: master ← Head: 513-fix

📝 Commits (6)

a1bb31d testing no remote sovlers
059082f written failing test which found the bug
0582814 test was wrong, feature is working
7c82e34 extracting to specific class
c291746 refactoring
6764132 created tests

📊 Changes

10 files changed (+272 additions, -73 deletions)

View changed files

📝 src/main/java/com/mageddo/dnsproxyserver/config/dataprovider/ConfigDAOJson.java (+2 -52)
📝 src/main/java/com/mageddo/dnsproxyserver/config/dataprovider/JsonConfigs.java (+8 -3)
➕ src/main/java/com/mageddo/dnsproxyserver/config/dataprovider/mapper/ConfigJsonV2Mapper.java (+58 -0)
📝 src/test/java/com/mageddo/dnsproxyserver/config/application/ConfigServiceCompTest.java (+47 -14)
📝 src/test/java/com/mageddo/dnsproxyserver/config/dataprovider/ConfigDAOJsonTest.java (+17 -4)
➕ src/test/java/com/mageddo/dnsproxyserver/config/dataprovider/mapper/ConfigJsonV2MapperTest.java (+46 -0)
➕ src/test/java/testing/templates/ConfigJsonTemplates.java (+18 -0)
➕ src/test/resources/configs-test/005.json (+28 -0)
➕ src/test/resources/configs-test/006.json (+28 -0)
➕ src/test/resources/configs-test/007.json (+20 -0)

📄 Description

Refactoring and tests created due #513 , before fixing the code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mageddo/dns-proxy-server/pull/514 **Author:** [@mageddo](https://github.com/mageddo) **Created:** 7/16/2024 **Status:** ✅ Merged **Merged:** 7/16/2024 **Merged by:** [@mageddo](https://github.com/mageddo) **Base:** `master` ← **Head:** `513-fix` --- ### 📝 Commits (6) - [`a1bb31d`](https://github.com/mageddo/dns-proxy-server/commit/a1bb31dee76acd4c37dfed935502b1421aa4e4c1) testing no remote sovlers - [`059082f`](https://github.com/mageddo/dns-proxy-server/commit/059082f9a84d947218bd06feedd7ca435dd24a17) written failing test which found the bug - [`0582814`](https://github.com/mageddo/dns-proxy-server/commit/0582814e73f0ae6164f9edeacd3e00891234f806) test was wrong, feature is working - [`7c82e34`](https://github.com/mageddo/dns-proxy-server/commit/7c82e3420ff363607d22a05c8bf2662fbb287b87) extracting to specific class - [`c291746`](https://github.com/mageddo/dns-proxy-server/commit/c2917462cec3078ee5cbbbae7e10443c207689f7) refactoring - [`6764132`](https://github.com/mageddo/dns-proxy-server/commit/67641327e67c0351aa6efc5dd2be0b723906aa40) created tests ### 📊 Changes **10 files changed** (+272 additions, -73 deletions) <details> <summary>View changed files</summary> 📝 `src/main/java/com/mageddo/dnsproxyserver/config/dataprovider/ConfigDAOJson.java` (+2 -52) 📝 `src/main/java/com/mageddo/dnsproxyserver/config/dataprovider/JsonConfigs.java` (+8 -3) ➕ `src/main/java/com/mageddo/dnsproxyserver/config/dataprovider/mapper/ConfigJsonV2Mapper.java` (+58 -0) 📝 `src/test/java/com/mageddo/dnsproxyserver/config/application/ConfigServiceCompTest.java` (+47 -14) 📝 `src/test/java/com/mageddo/dnsproxyserver/config/dataprovider/ConfigDAOJsonTest.java` (+17 -4) ➕ `src/test/java/com/mageddo/dnsproxyserver/config/dataprovider/mapper/ConfigJsonV2MapperTest.java` (+46 -0) ➕ `src/test/java/testing/templates/ConfigJsonTemplates.java` (+18 -0) ➕ `src/test/resources/configs-test/005.json` (+28 -0) ➕ `src/test/resources/configs-test/006.json` (+28 -0) ➕ `src/test/resources/configs-test/007.json` (+20 -0) </details> ### 📄 Description Refactoring and tests created due #513 , before fixing the code --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>