[PR #477] [MERGED] #474 Fixing error when fallback to host machine IP #520

Closed
opened 2026-02-26 04:35:31 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/mageddo/dns-proxy-server/pull/477
Author: @mageddo
Created: 6/17/2024
Status: Merged
Merged: 6/17/2024
Merged by: @mageddo

Base: masterHead: bugfix/474


📝 Commits (6)

  • 79dd891 logging net name
  • 4e5e72b leading with no ipam config and testing
  • 178f0ee dont use networks without ip
  • 693410f Merge remote-tracking branch 'origin/master' into bugfix/474
  • d05bd9d release notes
  • be69d73 [Gradle Release Plugin] - new version commit: '3.19.5-snapshot'.

📊 Changes

11 files changed (+118 additions, -15 deletions)

View changed files

📝 RELEASE-NOTES.md (+3 -0)
📝 gradle.properties (+1 -1)
📝 src/main/java/com/mageddo/dnsproxyserver/docker/domain/Drivers.java (+1 -0)
📝 src/main/java/com/mageddo/dnsproxyserver/solver/docker/Network.java (+11 -0)
📝 src/main/java/com/mageddo/dnsproxyserver/solver/docker/dataprovider/DockerDAODefault.java (+8 -2)
📝 src/main/java/com/mageddo/dnsproxyserver/solver/docker/dataprovider/mapper/NetworkMapper.java (+16 -10)
📝 src/test/java/com/mageddo/dnsproxyserver/solver/docker/dataprovider/DockerDAODefaultTest.java (+24 -1)
📝 src/test/java/com/mageddo/dnsproxyserver/solver/docker/dataprovider/mapper/NetworkMapperTest.java (+17 -1)
📝 src/test/java/testing/templates/docker/NetworkTemplates.java (+4 -0)
📝 src/test/java/testing/templates/server/dns/solver/docker/NetworkTemplates.java (+10 -0)
src/test/resources/templates/docker/network/003.json (+23 -0)

📄 Description

Fixing error when fallback to host machine IP, Network mapper fails when the mapped networks hasn't an IPAM config, it has more chances to happen on IPV6 query solving.

Relates to #474 .


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mageddo/dns-proxy-server/pull/477 **Author:** [@mageddo](https://github.com/mageddo) **Created:** 6/17/2024 **Status:** ✅ Merged **Merged:** 6/17/2024 **Merged by:** [@mageddo](https://github.com/mageddo) **Base:** `master` ← **Head:** `bugfix/474` --- ### 📝 Commits (6) - [`79dd891`](https://github.com/mageddo/dns-proxy-server/commit/79dd891c8b9e610a1b3b7e96962ea704c303e076) logging net name - [`4e5e72b`](https://github.com/mageddo/dns-proxy-server/commit/4e5e72b4e26e277ac3524e9725e67488f3b84f15) leading with no ipam config and testing - [`178f0ee`](https://github.com/mageddo/dns-proxy-server/commit/178f0ee41e53d74e7b1c1e943441df939e649a09) dont use networks without ip - [`693410f`](https://github.com/mageddo/dns-proxy-server/commit/693410f0a0be3ecb288731de98ac55ff15c649f5) Merge remote-tracking branch 'origin/master' into bugfix/474 - [`d05bd9d`](https://github.com/mageddo/dns-proxy-server/commit/d05bd9df707763159ad4739110f73208c14aa7e4) release notes - [`be69d73`](https://github.com/mageddo/dns-proxy-server/commit/be69d738a265732c85b17274169fdb9b7515bfa4) [Gradle Release Plugin] - new version commit: '3.19.5-snapshot'. ### 📊 Changes **11 files changed** (+118 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `RELEASE-NOTES.md` (+3 -0) 📝 `gradle.properties` (+1 -1) 📝 `src/main/java/com/mageddo/dnsproxyserver/docker/domain/Drivers.java` (+1 -0) 📝 `src/main/java/com/mageddo/dnsproxyserver/solver/docker/Network.java` (+11 -0) 📝 `src/main/java/com/mageddo/dnsproxyserver/solver/docker/dataprovider/DockerDAODefault.java` (+8 -2) 📝 `src/main/java/com/mageddo/dnsproxyserver/solver/docker/dataprovider/mapper/NetworkMapper.java` (+16 -10) 📝 `src/test/java/com/mageddo/dnsproxyserver/solver/docker/dataprovider/DockerDAODefaultTest.java` (+24 -1) 📝 `src/test/java/com/mageddo/dnsproxyserver/solver/docker/dataprovider/mapper/NetworkMapperTest.java` (+17 -1) 📝 `src/test/java/testing/templates/docker/NetworkTemplates.java` (+4 -0) 📝 `src/test/java/testing/templates/server/dns/solver/docker/NetworkTemplates.java` (+10 -0) ➕ `src/test/resources/templates/docker/network/003.json` (+23 -0) </details> ### 📄 Description Fixing error when fallback to host machine IP, Network mapper fails when the mapped networks hasn't an IPAM config, it has more chances to happen on IPV6 query solving. Relates to #474 . --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 04:35:31 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/dns-proxy-server-mageddo#520
No description provided.