[PR #459] [MERGED] #455 - Refactoring SolverRemote #508

New issue

Closed

opened 2026-02-26 04:35:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 04:35:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mageddo/dns-proxy-server/pull/459
Author: @mageddo
Created: 5/31/2024
Status: ✅ Merged
Merged: 5/31/2024
Merged by: @mageddo

Base: master ← Head: feat/455-refactoring

📝 Commits (10+)

2251f1d todos notes
6152f24 todos notes
4cb763a refactoring method
6092548 refactoring
5b218c0 extracting methods to classe
c44fb51 extracting resolver addr ping and query reponse wait to a specific class
58f8789 formatting
ab1e5b8 closing resources
86349aa removing unused code
c133f14 splitting into to two methods

📊 Changes

9 files changed (+283 additions, -114 deletions)

View changed files

📝 RELEASE-NOTES.md (+3 -0)
📝 gradle.properties (+1 -1)
📝 src/main/java/com/mageddo/dns/utils/Messages.java (+3 -0)
📝 src/main/java/com/mageddo/dnsproxyserver/solver/SolverRemote.java (+187 -105)
📝 src/main/java/com/mageddo/dnsproxyserver/utils/Ips.java (+4 -0)
📝 src/main/java/com/mageddo/dnsserver/TCPServer.java (+2 -2)
➕ src/main/java/com/mageddo/net/IpAddrs.java (+14 -0)
➕ src/main/java/com/mageddo/net/NetExecutorWatchdog.java (+68 -0)
📝 src/test/java/com/mageddo/dnsproxyserver/solver/SolverRemoteTest.java (+1 -6)

📄 Description

Related to #455

Purpose

Refactor SolverRemote class which is with really big methods, practice some clean code there.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mageddo/dns-proxy-server/pull/459 **Author:** [@mageddo](https://github.com/mageddo) **Created:** 5/31/2024 **Status:** ✅ Merged **Merged:** 5/31/2024 **Merged by:** [@mageddo](https://github.com/mageddo) **Base:** `master` ← **Head:** `feat/455-refactoring` --- ### 📝 Commits (10+) - [`2251f1d`](https://github.com/mageddo/dns-proxy-server/commit/2251f1d6739260b1f0d93f6489bf33d75417fbd0) todos notes - [`6152f24`](https://github.com/mageddo/dns-proxy-server/commit/6152f2439c26cd501abec9a1f20cacf2a04c42fc) todos notes - [`4cb763a`](https://github.com/mageddo/dns-proxy-server/commit/4cb763a35cc277539c5c1c05298791953330eb5b) refactoring method - [`6092548`](https://github.com/mageddo/dns-proxy-server/commit/60925488c22039a0829d9ce858cfe195541e95bb) refactoring - [`5b218c0`](https://github.com/mageddo/dns-proxy-server/commit/5b218c00a60cb1d605ebf4733664dd68b168749d) extracting methods to classe - [`c44fb51`](https://github.com/mageddo/dns-proxy-server/commit/c44fb51126e5f79bfe9ca9b9c533e5db01ee745c) extracting resolver addr ping and query reponse wait to a specific class - [`58f8789`](https://github.com/mageddo/dns-proxy-server/commit/58f8789db9524447770f17d1f4fac9d46546db05) formatting - [`ab1e5b8`](https://github.com/mageddo/dns-proxy-server/commit/ab1e5b8a13487b844d4108c6dac1ac1dbf382afc) closing resources - [`86349aa`](https://github.com/mageddo/dns-proxy-server/commit/86349aa88c1a3acb8c1a5e8578e19de1aadb188f) removing unused code - [`c133f14`](https://github.com/mageddo/dns-proxy-server/commit/c133f1450101b7c623793aea0badd144d1e77d68) splitting into to two methods ### 📊 Changes **9 files changed** (+283 additions, -114 deletions) <details> <summary>View changed files</summary> 📝 `RELEASE-NOTES.md` (+3 -0) 📝 `gradle.properties` (+1 -1) 📝 `src/main/java/com/mageddo/dns/utils/Messages.java` (+3 -0) 📝 `src/main/java/com/mageddo/dnsproxyserver/solver/SolverRemote.java` (+187 -105) 📝 `src/main/java/com/mageddo/dnsproxyserver/utils/Ips.java` (+4 -0) 📝 `src/main/java/com/mageddo/dnsserver/TCPServer.java` (+2 -2) ➕ `src/main/java/com/mageddo/net/IpAddrs.java` (+14 -0) ➕ `src/main/java/com/mageddo/net/NetExecutorWatchdog.java` (+68 -0) 📝 `src/test/java/com/mageddo/dnsproxyserver/solver/SolverRemoteTest.java` (+1 -6) </details> ### 📄 Description Related to #455 ## Purpose Refactor `SolverRemote` class which is with really big methods, practice some clean code there. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>