[PR #445] [MERGED] Do Refactoring encountered at #442 #498

Closed
opened 2026-02-26 04:35:26 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/mageddo/dns-proxy-server/pull/445
Author: @mageddo
Created: 5/13/2024
Status: Merged
Merged: 5/13/2024
Merged by: @mageddo

Base: masterHead: feat/444


📝 Commits (10+)

  • 16c7bae refactoring unnecessary parameter
  • f7adfe8 refactoring class packages
  • 284a538 isolating container solving in app layer
  • c4d9023 a lot of refactoring trying to separate solver.docker module application from dataprovider impl
  • 37c37ca app compiling errors fixed
  • 0d4ba7f testing container mapper
  • d10ca10 mustSolveSpecifiedNetworkFirst fixed
  • 00f8180 refactoring test location
  • 3d4f23f new test
  • a41c588 creating new test

📊 Changes

86 files changed (+2027 additions, -994 deletions)

View changed files

📝 src/main/java/com/mageddo/dnsproxyserver/config/Config.java (+1 -1)
📝 src/main/java/com/mageddo/dnsproxyserver/config/ConfigDAO.java (+2 -0)
📝 src/main/java/com/mageddo/dnsproxyserver/config/ConfigDAOJson.java (+5 -0)
📝 src/main/java/com/mageddo/dnsproxyserver/config/Configs.java (+1 -1)
📝 src/main/java/com/mageddo/dnsproxyserver/di/Context.java (+4 -7)
📝 src/main/java/com/mageddo/dnsproxyserver/di/module/ModuleDao.java (+29 -8)
📝 src/main/java/com/mageddo/dnsproxyserver/di/module/ModuleMap.java (+12 -12)
📝 src/main/java/com/mageddo/dnsproxyserver/di/module/ModuleStartup.java (+1 -1)
📝 src/main/java/com/mageddo/dnsproxyserver/dnsconfigurator/DnsConfigurators.java (+3 -2)
src/main/java/com/mageddo/dnsproxyserver/dnsconfigurator/DpsIpDiscover.java (+0 -32)
src/main/java/com/mageddo/dnsproxyserver/docker/ContainerDAO.java (+0 -12)
src/main/java/com/mageddo/dnsproxyserver/docker/ContainerSolvingService.java (+0 -180)
src/main/java/com/mageddo/dnsproxyserver/docker/DockerDAODefault.java (+0 -73)
src/main/java/com/mageddo/dnsproxyserver/docker/DockerDAOMock.java (+0 -43)
src/main/java/com/mageddo/dnsproxyserver/docker/DockerNetworkService.java (+0 -77)
src/main/java/com/mageddo/dnsproxyserver/docker/DpsContainerManager.java (+0 -170)
src/main/java/com/mageddo/dnsproxyserver/docker/MatchingContainerService.java (+0 -26)
src/main/java/com/mageddo/dnsproxyserver/docker/NetworkComparator.java (+0 -25)
📝 src/main/java/com/mageddo/dnsproxyserver/docker/application/Containers.java (+5 -2)
📝 src/main/java/com/mageddo/dnsproxyserver/docker/application/DockerConnectionCheck.java (+1 -1)

...and 66 more files

📄 Description

Fixes #444


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mageddo/dns-proxy-server/pull/445 **Author:** [@mageddo](https://github.com/mageddo) **Created:** 5/13/2024 **Status:** ✅ Merged **Merged:** 5/13/2024 **Merged by:** [@mageddo](https://github.com/mageddo) **Base:** `master` ← **Head:** `feat/444` --- ### 📝 Commits (10+) - [`16c7bae`](https://github.com/mageddo/dns-proxy-server/commit/16c7bae4279947f76539454ebc9fc1fd359c1268) refactoring unnecessary parameter - [`f7adfe8`](https://github.com/mageddo/dns-proxy-server/commit/f7adfe83b0be626909e60d99b43e2b3e7bbf8889) refactoring class packages - [`284a538`](https://github.com/mageddo/dns-proxy-server/commit/284a538b65cc8fcd2086d7321276fbfc541d0ce2) isolating container solving in app layer - [`c4d9023`](https://github.com/mageddo/dns-proxy-server/commit/c4d9023c0783ee75dc8493079741bc225ac6271c) a lot of refactoring trying to separate solver.docker module application from dataprovider impl - [`37c37ca`](https://github.com/mageddo/dns-proxy-server/commit/37c37cacf0c9c4c2d520f8550e35a5e7e989e9e7) app compiling errors fixed - [`0d4ba7f`](https://github.com/mageddo/dns-proxy-server/commit/0d4ba7f3b6ae70561bfc0c0a46ccd4774bb3a5eb) testing container mapper - [`d10ca10`](https://github.com/mageddo/dns-proxy-server/commit/d10ca10030c0a46eafa24bac849d6d9dc3664f16) mustSolveSpecifiedNetworkFirst fixed - [`00f8180`](https://github.com/mageddo/dns-proxy-server/commit/00f8180fbcc6224045dcae409230b048dc308899) refactoring test location - [`3d4f23f`](https://github.com/mageddo/dns-proxy-server/commit/3d4f23f775e79c9c60c41119bf14527ce3de081b) new test - [`a41c588`](https://github.com/mageddo/dns-proxy-server/commit/a41c588f21bf1c36a5474fc03f901614807f49a0) creating new test ### 📊 Changes **86 files changed** (+2027 additions, -994 deletions) <details> <summary>View changed files</summary> 📝 `src/main/java/com/mageddo/dnsproxyserver/config/Config.java` (+1 -1) 📝 `src/main/java/com/mageddo/dnsproxyserver/config/ConfigDAO.java` (+2 -0) 📝 `src/main/java/com/mageddo/dnsproxyserver/config/ConfigDAOJson.java` (+5 -0) 📝 `src/main/java/com/mageddo/dnsproxyserver/config/Configs.java` (+1 -1) 📝 `src/main/java/com/mageddo/dnsproxyserver/di/Context.java` (+4 -7) 📝 `src/main/java/com/mageddo/dnsproxyserver/di/module/ModuleDao.java` (+29 -8) 📝 `src/main/java/com/mageddo/dnsproxyserver/di/module/ModuleMap.java` (+12 -12) 📝 `src/main/java/com/mageddo/dnsproxyserver/di/module/ModuleStartup.java` (+1 -1) 📝 `src/main/java/com/mageddo/dnsproxyserver/dnsconfigurator/DnsConfigurators.java` (+3 -2) ➖ `src/main/java/com/mageddo/dnsproxyserver/dnsconfigurator/DpsIpDiscover.java` (+0 -32) ➖ `src/main/java/com/mageddo/dnsproxyserver/docker/ContainerDAO.java` (+0 -12) ➖ `src/main/java/com/mageddo/dnsproxyserver/docker/ContainerSolvingService.java` (+0 -180) ➖ `src/main/java/com/mageddo/dnsproxyserver/docker/DockerDAODefault.java` (+0 -73) ➖ `src/main/java/com/mageddo/dnsproxyserver/docker/DockerDAOMock.java` (+0 -43) ➖ `src/main/java/com/mageddo/dnsproxyserver/docker/DockerNetworkService.java` (+0 -77) ➖ `src/main/java/com/mageddo/dnsproxyserver/docker/DpsContainerManager.java` (+0 -170) ➖ `src/main/java/com/mageddo/dnsproxyserver/docker/MatchingContainerService.java` (+0 -26) ➖ `src/main/java/com/mageddo/dnsproxyserver/docker/NetworkComparator.java` (+0 -25) 📝 `src/main/java/com/mageddo/dnsproxyserver/docker/application/Containers.java` (+5 -2) 📝 `src/main/java/com/mageddo/dnsproxyserver/docker/application/DockerConnectionCheck.java` (+1 -1) _...and 66 more files_ </details> ### 📄 Description Fixes #444 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 04:35:26 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/dns-proxy-server-mageddo#498
No description provided.