starred/dns-proxy-server-mageddo

Fork 0

mirror of https://github.com/mageddo/dns-proxy-server.git synced 2026-04-25 17:35:54 +03:00

[GH-ISSUE #121] No way to specify upstream/remote DNS server port #49

New issue

Closed

opened 2026-02-26 04:33:53 +03:00 by kerem · 6 comments

kerem commented

2026-02-26 04:33:53 +03:00

Owner

Originally created by @ammmze on GitHub (Apr 18, 2019).
Original GitHub issue: https://github.com/mageddo/dns-proxy-server/issues/121

I'd like to include the Consul DNS server as one of the remote name servers, but it looks like it only accepts the IP address as an array of numbers. Ideally we should be able to include the port in the remote dns server settings. Honestly I'd prefer to be able to just configure it as "remoteDnsServers": ["172.16.33.33:8600"], which means you'd need to parse the port out because it looks like the parameters you pass into your function to add the host is the ip address and then the port as a separate parameter.

Originally created by @ammmze on GitHub (Apr 18, 2019). Original GitHub issue: https://github.com/mageddo/dns-proxy-server/issues/121 I'd like to include the Consul DNS server as one of the remote name servers, but it looks like it only accepts the IP address as an array of numbers. Ideally we should be able to include the port in the remote dns server settings. Honestly I'd prefer to be able to just configure it as `"remoteDnsServers": ["172.16.33.33:8600"]`, which means you'd need to parse the port out because it looks like the parameters you pass into your function to add the host is the ip address and then the port as a separate parameter.

kerem

2026-02-26 04:33:53 +03:00

closed this issue
added the
feature
label

kerem commented

2026-02-26 04:33:54 +03:00

Author

Owner

@mageddo commented on GitHub (Apr 18, 2019):

I agree we would migrate the remoteDnsServers variable to an string instead of array of ints.

I'd like to include the Consul DNS server as one of the remote name servers

Is Your current problem that you can't specify the port or the remote server as a array is not suitable to you?

@mageddo commented on GitHub (Apr 18, 2019): I agree we would migrate the remoteDnsServers variable to an string instead of array of ints. > I'd like to include the Consul DNS server as one of the remote name servers Is Your current problem that you can't specify the port or the remote server as a array is not suitable to you?

kerem commented

2026-02-26 04:33:54 +03:00

Author

Owner

@ammmze commented on GitHub (Apr 19, 2019):

My current hold up is not being able specify the port. Migration to a string would just be a nice to have

@ammmze commented on GitHub (Apr 19, 2019): My current hold up is not being able specify the port. Migration to a string would just be a nice to have

kerem commented

2026-02-26 04:33:54 +03:00

Author

Owner

@mageddo commented on GitHub (Apr 22, 2019):

What is expected

💡 A way to specify the remote servers port

If not port were specified then 53 have to be assumed
Change json contract to specify Remover Server using string instead of array of bytes

current contract

{
  "remoteDnsServers": [[208,67,222,222]],
}

proposed contract

{
  "remoteDnsServers": ["208.67.222.222", "208.67.222.223:5353"],
}

💡 Change hostname ip contract

Contract today is array of bytes, as discussed before use a string instead of the array may be more clear to read and meaningful when the port have to be specified, as the remote server will change to the string format it makes sense to change that field also

@mageddo commented on GitHub (Apr 22, 2019): ### What is expected __:bulb: A way to specify the remote servers port__ * [x] If not port were specified then `53` have to be assumed * [x] Change json contract to specify Remover Server using string instead of array of bytes current contract ```json { "remoteDnsServers": [[208,67,222,222]], } ``` proposed contract ```json { "remoteDnsServers": ["208.67.222.222", "208.67.222.223:5353"], } ``` __:bulb: Change hostname ip contract__ Contract today is array of bytes, as discussed before use a string instead of the array may be more clear to read and meaningful when the port have to be specified, as the remote server will change to the string format it makes sense to change that field also

kerem commented

2026-02-26 04:33:54 +03:00

Author

Owner

@mageddo commented on GitHub (May 5, 2019):

DPS was released and the docs updated, see http://mageddo.github.io/dns-proxy-server/2.14/en/3-configuration/

@mageddo commented on GitHub (May 5, 2019): DPS was released and the docs updated, see http://mageddo.github.io/dns-proxy-server/2.14/en/3-configuration/

kerem commented

2026-02-26 04:33:54 +03:00

Author

Owner

@mageddo commented on GitHub (May 5, 2019):

@ammmze thanks for your contribution, feel Free to make any report when you need

@mageddo commented on GitHub (May 5, 2019): @ammmze thanks for your contribution, feel Free to make any report when you need

kerem commented

2026-02-26 04:33:54 +03:00

Author

Owner

@ammmze commented on GitHub (May 9, 2019):

Awesome! I'm glad to see you also switched the other instances of IP addresses to strings 🙂 thanks a bunch

@ammmze commented on GitHub (May 9, 2019): Awesome! I'm glad to see you also switched the other instances of IP addresses to strings 🙂 thanks a bunch

kerem referenced this issue

2026-02-26 04:34:36 +03:00

[PR #49] [MERGED] Feature/47 #245