[PR #170] [MERGED] Fix presence check of config setting "domain" #314

New issue

Closed

opened 2026-02-26 04:34:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 04:34:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mageddo/dns-proxy-server/pull/170
Author: @mrubli
Created: 11/28/2019
Status: ✅ Merged
Merged: 1/3/2020
Merged by: @mageddo

Base: master ← Head: bugfix/config-domain-check

📝 Commits (1)

434fc04 Fix presence check of config setting "domain"

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 conf/conf.go (+1 -1)

📄 Description

The existing check accidentally checked the length of the HostMachineHostname
instead of the Domain configuration setting to determine if the Domain setting
was present.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mageddo/dns-proxy-server/pull/170 **Author:** [@mrubli](https://github.com/mrubli) **Created:** 11/28/2019 **Status:** ✅ Merged **Merged:** 1/3/2020 **Merged by:** [@mageddo](https://github.com/mageddo) **Base:** `master` ← **Head:** `bugfix/config-domain-check` --- ### 📝 Commits (1) - [`434fc04`](https://github.com/mageddo/dns-proxy-server/commit/434fc043633bf2e467e9ee6b8986f008f6370019) Fix presence check of config setting "domain" ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `conf/conf.go` (+1 -1) </details> ### 📄 Description The existing check accidentally checked the length of the HostMachineHostname instead of the Domain configuration setting to determine if the Domain setting was present. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>