[PR #169] [MERGED] Resolving docker services using configured DPS domain. #312

New issue

Closed

opened 2026-02-26 04:34:49 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 04:34:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mageddo/dns-proxy-server/pull/169
Author: @imartinezortiz
Created: 11/5/2019
Status: ✅ Merged
Merged: 1/3/2020
Merged by: @mageddo

Base: master ← Head: docker-service-dps-domain

📝 Commits (1)

0119da0 Resolving docker services using configured DPS domain.

📊 Changes

2 files changed (+4 additions, -3 deletions)

View changed files

📝 events/docker/docker.go (+1 -1)
📝 events/docker/docker_test.go (+3 -2)

📄 Description

Currently to resolve docker service names, DPS always add ".docker" suffix to the docker service name, I guess because this is the default DPS domain.

This PR modifies this behavior to use the configured DPS domain instead of the default "docker" domain.

Tests have been modified to reflect the docker-compose behavior of adding "_1" to the container name created for a docker service.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mageddo/dns-proxy-server/pull/169 **Author:** [@imartinezortiz](https://github.com/imartinezortiz) **Created:** 11/5/2019 **Status:** ✅ Merged **Merged:** 1/3/2020 **Merged by:** [@mageddo](https://github.com/mageddo) **Base:** `master` ← **Head:** `docker-service-dps-domain` --- ### 📝 Commits (1) - [`0119da0`](https://github.com/mageddo/dns-proxy-server/commit/0119da07f738f6bbf72773276bae401e7c780bc5) Resolving docker services using configured DPS domain. ### 📊 Changes **2 files changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `events/docker/docker.go` (+1 -1) 📝 `events/docker/docker_test.go` (+3 -2) </details> ### 📄 Description Currently to resolve docker service names, DPS always add ".docker" suffix to the docker service name, I guess because this is the default DPS domain. This PR modifies this behavior to use the configured DPS domain instead of the default "docker" domain. Tests have been modified to reflect the docker-compose behavior of adding "_1" to the container name created for a docker service. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>