[PR #122] [MERGED] Refactoring Storage API #286

New issue

Closed

opened 2026-02-26 04:34:44 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 04:34:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mageddo/dns-proxy-server/pull/122
Author: @mageddo
Created: 4/21/2019
Status: ✅ Merged
Merged: 4/22/2019
Merged by: @mageddo

Base: master ← Head: feature/121

📝 Commits (10+)

c058435 extracting storage vos from config package
01fbc4a fixing cyclic reference
a6f5e43 refactoring package
ab72ed1 renaming structs
4a98e90 reordering methods and removing comments
c10f742 implementing maps, id is not necessary anymore
0ea0c66 fixing config mapping
a859f6e refactoring package
7039712 fixing env api
ea23e46 fixing envs retrieve

📊 Changes

33 files changed (+1086 additions, -486 deletions)

View changed files

📝 .travis.yml (+5 -2)
📝 Dockerfile.builder (+3 -0)
➕ Dockerfile.go.builder (+6 -0)
📝 RELEASE-NOTES.md (+4 -0)
📝 VERSION (+1 -1)
📝 builder.bash (+4 -0)
📝 conf/conf.go (+4 -3)
📝 conf/conf_test.go (+6 -3)
📝 controller/v1/cache.go (+1 -1)
📝 controller/v1/cache_test.go (+1 -1)
📝 controller/v1/env.go (+35 -39)
📝 controller/v1/env_test.go (+41 -18)
📝 controller/v1/hostname.go (+27 -33)
📝 controller/v1/hostname_test.go (+54 -20)
📝 controller/v1/index.go (+4 -3)
📝 controller/v1/statics.go (+1 -1)
➕ controller/v1/vo/env.go (+30 -0)
➕ controller/v1/vo/hostname.go (+61 -0)
📝 dns.go (+8 -4)
📝 docker-compose.yml (+25 -6)

...and 13 more files

📄 Description

Refactoring storage API separating the vos that are used to store, respond the rest api and used at the DNS questions, this will be helpful when a new store api version required

Tasks

Refactoring store api separating store, rest api and configuration vos it will make #121 easier
Fix automated tests
Manual tests for the gui
Manual tests for dns resolution

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mageddo/dns-proxy-server/pull/122 **Author:** [@mageddo](https://github.com/mageddo) **Created:** 4/21/2019 **Status:** ✅ Merged **Merged:** 4/22/2019 **Merged by:** [@mageddo](https://github.com/mageddo) **Base:** `master` ← **Head:** `feature/121` --- ### 📝 Commits (10+) - [`c058435`](https://github.com/mageddo/dns-proxy-server/commit/c0584354579a1e66328f419189f7eef162561921) extracting storage vos from config package - [`01fbc4a`](https://github.com/mageddo/dns-proxy-server/commit/01fbc4a5a561743ad95a88a621f18924aa2c258c) fixing cyclic reference - [`a6f5e43`](https://github.com/mageddo/dns-proxy-server/commit/a6f5e432f784c29e08b110383f360cc95618c330) refactoring package - [`ab72ed1`](https://github.com/mageddo/dns-proxy-server/commit/ab72ed15f2589e4e04c57c10e9eb6e98e13dba6e) renaming structs - [`4a98e90`](https://github.com/mageddo/dns-proxy-server/commit/4a98e90b34492a224c3e971381d12aca006e0b9d) reordering methods and removing comments - [`c10f742`](https://github.com/mageddo/dns-proxy-server/commit/c10f742c109fb372284949ecc46fd5e1d0430b22) implementing maps, id is not necessary anymore - [`0ea0c66`](https://github.com/mageddo/dns-proxy-server/commit/0ea0c660aaedf0129ada182810c5097dec4c4ff4) fixing config mapping - [`a859f6e`](https://github.com/mageddo/dns-proxy-server/commit/a859f6e3a156bc31eabb878b90f0aeac2c07e0e1) refactoring package - [`7039712`](https://github.com/mageddo/dns-proxy-server/commit/7039712c443df4a39f9dd44da4881c21e3c4bc58) fixing env api - [`ea23e46`](https://github.com/mageddo/dns-proxy-server/commit/ea23e468bff256caca4653acae6c6a274b9cbd0c) fixing envs retrieve ### 📊 Changes **33 files changed** (+1086 additions, -486 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+5 -2) 📝 `Dockerfile.builder` (+3 -0) ➕ `Dockerfile.go.builder` (+6 -0) 📝 `RELEASE-NOTES.md` (+4 -0) 📝 `VERSION` (+1 -1) 📝 `builder.bash` (+4 -0) 📝 `conf/conf.go` (+4 -3) 📝 `conf/conf_test.go` (+6 -3) 📝 `controller/v1/cache.go` (+1 -1) 📝 `controller/v1/cache_test.go` (+1 -1) 📝 `controller/v1/env.go` (+35 -39) 📝 `controller/v1/env_test.go` (+41 -18) 📝 `controller/v1/hostname.go` (+27 -33) 📝 `controller/v1/hostname_test.go` (+54 -20) 📝 `controller/v1/index.go` (+4 -3) 📝 `controller/v1/statics.go` (+1 -1) ➕ `controller/v1/vo/env.go` (+30 -0) ➕ `controller/v1/vo/hostname.go` (+61 -0) 📝 `dns.go` (+8 -4) 📝 `docker-compose.yml` (+25 -6) _...and 13 more files_ </details> ### 📄 Description Refactoring storage API separating the vos that are used to store, respond the rest api and used at the DNS questions, this will be helpful when a new store api version required **Tasks** * [x] Refactoring store api separating store, rest api and configuration vos it will make #121 easier * [x] Fix automated tests * [x] Manual tests for the gui * [x] Manual tests for dns resolution --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>