starred/dns-proxy-server-mageddo

Fork 0

mirror of https://github.com/mageddo/dns-proxy-server.git synced 2026-04-25 17:35:54 +03:00

[GH-ISSUE #55] DNS missing HOSTNAMES env from neighbors container #24

New issue

Closed

opened 2026-02-26 04:33:48 +03:00 by kerem · 6 comments

kerem commented

2026-02-26 04:33:48 +03:00

Owner

Originally created by @andrezaycev on GitHub (Jan 11, 2018).
Original GitHub issue: https://github.com/mageddo/dns-proxy-server/issues/55

Originally assigned to: @mageddo on GitHub.

Hello.

We have issue:
if some containers started later than dns-proxy (for example longstart database), dns is not learning their HOSTNAMES variable (detected missing in proxy log)

We fix it over force-restart dns-proxy container in the end.

Tell me please how often dns-proxy have refresh HOSTNAMES vars from neighbor? Maybe possible to add parameter for it (reduce to 1 min for example)?

Originally created by @andrezaycev on GitHub (Jan 11, 2018). Original GitHub issue: https://github.com/mageddo/dns-proxy-server/issues/55 Originally assigned to: @mageddo on GitHub. Hello. We have issue: if some containers started later than dns-proxy (for example longstart database), dns is not learning their HOSTNAMES variable (detected missing in proxy log) We fix it over force-restart dns-proxy container in the end. Tell me please how often dns-proxy have refresh HOSTNAMES vars from neighbor? Maybe possible to add parameter for it (reduce to 1 min for example)?

kerem

2026-02-26 04:33:48 +03:00

closed this issue
added the
bug
label

kerem commented

2026-02-26 04:33:48 +03:00

Author

Owner

@mageddo commented on GitHub (Jan 11, 2018):

It happens only at SO startup or at any moment? I think I experienced this bug before but I couldn't confirm it.

Actually there isn't a refresh interval DPS uses Docker API library events

github.com/mageddo/dns-proxy-server@4a4de3c/events/docker/DockerEvents.go (L43)

Maybe I missed some configuration in that API

@mageddo commented on GitHub (Jan 11, 2018): It happens only at SO startup or at any moment? I think I experienced this bug before but I couldn't confirm it. Actually there isn't a refresh interval DPS uses [Docker API](http://github.com/docker/engine-api/) library events https://github.com/mageddo/dns-proxy-server/blob/4a4de3c/events/docker/DockerEvents.go#L43 Maybe I missed some configuration in that API

kerem commented

2026-02-26 04:33:48 +03:00

Author

Owner

@andrezaycev commented on GitHub (Jan 11, 2018):

Detect it on startup. i'm use docker-machine for develop. It's happenning when containers autostart after virtualbox starting

@andrezaycev commented on GitHub (Jan 11, 2018): Detect it on startup. i'm use docker-machine for develop. It's happenning when containers autostart after virtualbox starting

kerem commented

2026-02-26 04:33:48 +03:00

Author

Owner

@mageddo commented on GitHub (Jan 11, 2018):

Thanks for the feedback, I think a figure out a problem in that code.

When dns-proxy-server starts it gets a list of all started containers
Then it register itself at Docker events
I think there is a gap between the containers list and the events registration, If some container starts at this time it will not be registered. That's simple to fix so we can fix it and see what happens.
Basically we need to register in Docker events first, then list the containers, it can provide duplicated records but that is not a problem

Please confirm If this issue is intermittent (don't happens every time even in the same situation)

@mageddo commented on GitHub (Jan 11, 2018): Thanks for the feedback, I think a figure out a problem in that code. * When dns-proxy-server starts it gets a list of all started containers * Then it register itself at Docker events * I think there is a gap between the containers list and the events registration, If some container starts at this time it will not be registered. That's simple to fix so we can fix it and see what happens. * Basically we need to register in Docker events first, then list the containers, it can provide duplicated records but that is not a problem Please confirm If this issue is intermittent (don't happens every time even in the same situation)

kerem commented

2026-02-26 04:33:48 +03:00

Author

Owner

@mageddo commented on GitHub (Jan 11, 2018):

After that I can try to update the Docker client API.

@mageddo commented on GitHub (Jan 11, 2018): After that I can try to update the Docker client API.

kerem commented

2026-02-26 04:33:48 +03:00

Author

Owner

@mageddo commented on GitHub (Jan 11, 2018):

Please checkout the new release with a possible fix, then let me know if it works for you. If not then send me a log file dump since machine startup

@mageddo commented on GitHub (Jan 11, 2018): Please checkout [the new release](https://github.com/mageddo/dns-proxy-server/releases/tag/2.2.3) with a possible fix, then let me know if it works for you. If not then send me a log file dump since machine startup

kerem commented

2026-02-26 04:33:48 +03:00

Author

Owner

@andrezaycev commented on GitHub (Jan 12, 2018):

Thanks man. Will check in dynamic nearest week. Will write feedback later

@andrezaycev commented on GitHub (Jan 12, 2018): Thanks man. Will check in dynamic nearest week. Will write feedback later

kerem referenced this issue

2026-02-26 04:34:33 +03:00

[PR #24] [MERGED] Feature/mg 359 - Service stopped of work in normal mode #228