mirror of
https://github.com/mageddo/dns-proxy-server.git
synced 2026-04-25 09:25:56 +03:00
[GH-ISSUE #446] 3.17.1: java.lang.NullPointerException with MG_DOCKER_SOLVER_HOST_MACHINE_FALLBACK_ACTIVE: 'false' & no IPv6 #161
Labels
No labels
bug
confirmed
discussion
duplicate
enhancement
feature
feature-request
not-planned
pull-request
secondary-feature
stale
triage
waiting-feedback
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/dns-proxy-server-mageddo#161
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pschiffe on GitHub (May 15, 2024).
Original GitHub issue: https://github.com/mageddo/dns-proxy-server/issues/446
What is Happening / What is expected
Version
3.17.1withMG_DOCKER_SOLVER_HOST_MACHINE_FALLBACK_ACTIVE: 'false'seems to stop working for me due toNullPointerException. Dig doesn't return anything, if container has no IPv6:However, it works if container has IPv4 & IPv6:
Related to #429 and #442
Worked OK with 3.17.0
Specs
docker version3.17.1./dns-proxy-server --versiondocker run --rm defreitas/dns-proxy-server --version@mageddo commented on GitHub (May 22, 2024):
Probably because
findGatewayIp(n, IP.Version.IPV6)is returning null andList.of(null)throws NPE. A unit test is missing there.github.com/mageddo/dns-proxy-server@4579c48c15/src/main/java/com/mageddo/dnsproxyserver/server/dns/solver/docker/dataprovider/mapper/NetworkMapper.java (L14-L17)@mageddo commented on GitHub (May 22, 2024):
I don't have much time right now, I'm fixing this specific issue I've found and generating a new release at #448 , can you check if it fixes the whole scenario?
@pschiffe commented on GitHub (May 22, 2024):
Sure, I'll let you know.
@pschiffe commented on GitHub (May 22, 2024):
LGTM, thank you:
Resolved in https://github.com/mageddo/dns-proxy-server/releases/tag/3.17.2-snapshot