starred/dns-proxy-server-mageddo
1
0
Fork 0
mirror of https://github.com/mageddo/dns-proxy-server.git synced 2026-04-25 09:25:56 +03:00
Code Issues 10 Projects Releases 10 Packages Wiki Activity

[GH-ISSUE #395] Hang up on nonexistent domains or timeouts #141

New issue
Closed
opened 2026-02-26 04:34:10 +03:00 by kerem · 5 comments
kerem commented 2026-02-26 04:34:10 +03:00
Owner
Copy link

Originally created by @Sajito on GitHub (Mar 22, 2023).
Original GitHub issue: https://github.com/mageddo/dns-proxy-server/issues/395

Originally assigned to: @mageddo on GitHub.

What is Happening / What is expected

I'm not quiet sure if this relates to nonexistent domain or is always the case if a query times out.
When querying for a domain DPS, tries every solver available, each with a timeout of 10 seconds, until it get's a response or every solver failed.
If the domain does not exist, DPS needs multiple minutes to try each solver. While it is trying them, any other request will not be processed.

Steps to reproduce:

  • Start DPS
  • Query for a nonexistent domain, eg. asd.asd
    • This will timeout after some seconds
  • Now query a real domain, eg. google.com
    • This will also timeout now after some seconds
  • After some minutes, queries will work again

Specs

  • OS: EndeavourOS
  • Docker Version:
Client:
 Version:           23.0.1
 API version:       1.42
 Go version:        go1.20
 Git commit:        a5ee5b1dfc
 Built:             Sat Feb 11 13:58:04 2023
 OS/Arch:           linux/amd64
 Context:           default

Server:
 Engine:
  Version:          23.0.1
  API version:      1.42 (minimum version 1.12)
  Go version:       go1.20
  Git commit:       bc3805a0a0
  Built:            Sat Feb 11 13:58:04 2023
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          v1.7.0
  GitCommit:        1fbd70374134b891f97ce19c70b6e50c7b9f4e0d.m
 runc:
  Version:          1.1.4
  GitCommit:        
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0
  • DPS Version: Tried with 3.13.1 and 3.15.2-snapshot. Somewhere between these two versions something changed. In 3.13.1 only a timeout message is logged. In 3.15.2-snapshot a NullPointerException is logged after the timeout message.

Sorry for the missing log, I'm in a hurry right now, but I think this should be fairly easy to reproduce.

Originally created by @Sajito on GitHub (Mar 22, 2023). Original GitHub issue: https://github.com/mageddo/dns-proxy-server/issues/395 Originally assigned to: @mageddo on GitHub. ### What is Happening / What is expected I'm not quiet sure if this relates to nonexistent domain or is always the case if a query times out. When querying for a domain DPS, tries every solver available, each with a timeout of 10 seconds, until it get's a response or every solver failed. If the domain does not exist, DPS needs multiple minutes to try each solver. While it is trying them, any other request will not be processed. Steps to reproduce: - Start DPS - Query for a nonexistent domain, eg. `asd.asd` - This will timeout after some seconds - Now query a real domain, eg. `google.com` - This will also timeout now after some seconds - After some minutes, queries will work again ### Specs * OS: EndeavourOS * Docker Version: ``` Client: Version: 23.0.1 API version: 1.42 Go version: go1.20 Git commit: a5ee5b1dfc Built: Sat Feb 11 13:58:04 2023 OS/Arch: linux/amd64 Context: default Server: Engine: Version: 23.0.1 API version: 1.42 (minimum version 1.12) Go version: go1.20 Git commit: bc3805a0a0 Built: Sat Feb 11 13:58:04 2023 OS/Arch: linux/amd64 Experimental: false containerd: Version: v1.7.0 GitCommit: 1fbd70374134b891f97ce19c70b6e50c7b9f4e0d.m runc: Version: 1.1.4 GitCommit: docker-init: Version: 0.19.0 GitCommit: de40ad0 ``` * DPS Version: Tried with 3.13.1 and 3.15.2-snapshot. Somewhere between these two versions something changed. In 3.13.1 only a timeout message is logged. In 3.15.2-snapshot a NullPointerException is logged after the timeout message. Sorry for the missing log, I'm in a hurry right now, but I think this should be fairly easy to reproduce.
kerem 2026-02-26 04:34:10 +03:00
kerem commented 2026-02-26 04:34:10 +03:00
Author
Owner
Copy link

@mageddo commented on GitHub (Mar 22, 2023):

Hey, I'm not able to reproduce when using DPS with default options

time nslookup asd.asd 
Server:		172.17.0.4
Address:	172.17.0.4#53

** server can't find asd.asd: NXDOMAIN


real	0m0.022s
user	0m0.003s
sys	0m0.009s
typer@typer-pc:~$ time nslookup google.com 
Server:		172.17.0.4
Address:	172.17.0.4#53

Non-authoritative answer:
Name:	google.com
Address: 142.251.132.46
Name:	google.com
Address: 2800:3f0:4001:828::200e


real	0m0.023s
user	0m0.006s
sys	0m0.007s

I suppose it's related to the remote server you're using, maybe it is taking more than 10 seconds to answsr (DPS timeout is set 10s) then returns null. In that case the slowness is related to the proxied server.

I will make a test with a bad remote server to see if I get a NPE.

<!-- gh-comment-id:1479530751 --> @mageddo commented on GitHub (Mar 22, 2023): Hey, I'm not able to reproduce when using DPS with default options ``` time nslookup asd.asd Server: 172.17.0.4 Address: 172.17.0.4#53 ** server can't find asd.asd: NXDOMAIN real 0m0.022s user 0m0.003s sys 0m0.009s typer@typer-pc:~$ time nslookup google.com Server: 172.17.0.4 Address: 172.17.0.4#53 Non-authoritative answer: Name: google.com Address: 142.251.132.46 Name: google.com Address: 2800:3f0:4001:828::200e real 0m0.023s user 0m0.006s sys 0m0.007s ``` I suppose it's related to the remote server you're using, maybe it is taking more than 10 seconds to answsr (DPS timeout is set 10s) then returns null. In that case the slowness is related to the proxied server. I will make a test with a bad remote server to see if I get a NPE.
kerem commented 2026-02-26 04:34:10 +03:00
Author
Owner
Copy link

@mageddo commented on GitHub (Mar 22, 2023):

Okay... the NPE bug is confirmed when using a bad remote server which will never respond (8.8.8.8:85), I will work to fix that soon, no sure if it will increase your speed experience as your remote server is taking too long to respond.

10:03:08.178 [Thread-9       ] INF c.m.dnsproxyserver.server.dns.solver.SolverRemote l=47   m=handle                          status=timedOut, req=google.com, msg=Timed out while trying to resolve google.com./A, id=34124 class=IOException
10:03:08.179 [Thread-9       ] DEB c.m.dnsproxyserver.server.dns.solver.SolverCache  l=42   m=lambda$handleRes$0              status=noAnswer, action=cantCache, k=A-google.com
10:03:08.179 [Thread-9       ] WAR c.m.d.server.dns.RequestHandlerDefault            l=82   m=solve0                          status=solverFailed, currentSolverTime=10006, totalTime=10115, solver=SolverCachedRemote, eClass=NullPointerException, msg=Cannot invoke "com.mageddo.dnsproxyserver.server.dns.solver.Response.toBuilder()" because "res" is null
java.lang.NullPointerException: Cannot invoke "com.mageddo.dnsproxyserver.server.dns.solver.Response.toBuilder()" because "res" is null
	at com.mageddo.dnsproxyserver.server.dns.solver.SolverCachedRemote.handle(SolverCachedRemote.java:35)
	at com.mageddo.dnsproxyserver.server.dns.RequestHandlerDefault.solve0(RequestHandlerDefault.java:68)
	at com.mageddo.dnsproxyserver.server.dns.solver.SolverCache.lambda$handleRes$0(SolverCache.java:40)
	at com.mageddo.commons.caching.LruTTLCache.computeIfAbsent0(LruTTLCache.java:82)
	at com.mageddo.dnsproxyserver.server.dns.solver.SolverCache.handleRes(SolverCache.java:38)
	at com.mageddo.dnsproxyserver.server.dns.solver.SolverCache.handle(SolverCache.java:33)
	at com.mageddo.dnsproxyserver.server.dns.RequestHandlerDefault.solve(RequestHandlerDefault.java:46)
	at com.mageddo.dnsproxyserver.server.dns.RequestHandlerDefault.handle(RequestHandlerDefault.java:38)
	at com.mageddo.dnsproxyserver.server.dns.UDPServer.handle(UDPServer.java:54)
	at com.mageddo.dnsproxyserver.server.dns.UDPServer.lambda$start0$0(UDPServer.java:42)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:577)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1589)
<!-- gh-comment-id:1479537575 --> @mageddo commented on GitHub (Mar 22, 2023): Okay... the NPE bug is confirmed when using a bad remote server which will never respond (8.8.8.8:85), I will work to fix that soon, no sure if it will increase your speed experience as your remote server is taking too long to respond. ``` 10:03:08.178 [Thread-9 ] INF c.m.dnsproxyserver.server.dns.solver.SolverRemote l=47 m=handle status=timedOut, req=google.com, msg=Timed out while trying to resolve google.com./A, id=34124 class=IOException 10:03:08.179 [Thread-9 ] DEB c.m.dnsproxyserver.server.dns.solver.SolverCache l=42 m=lambda$handleRes$0 status=noAnswer, action=cantCache, k=A-google.com 10:03:08.179 [Thread-9 ] WAR c.m.d.server.dns.RequestHandlerDefault l=82 m=solve0 status=solverFailed, currentSolverTime=10006, totalTime=10115, solver=SolverCachedRemote, eClass=NullPointerException, msg=Cannot invoke "com.mageddo.dnsproxyserver.server.dns.solver.Response.toBuilder()" because "res" is null java.lang.NullPointerException: Cannot invoke "com.mageddo.dnsproxyserver.server.dns.solver.Response.toBuilder()" because "res" is null at com.mageddo.dnsproxyserver.server.dns.solver.SolverCachedRemote.handle(SolverCachedRemote.java:35) at com.mageddo.dnsproxyserver.server.dns.RequestHandlerDefault.solve0(RequestHandlerDefault.java:68) at com.mageddo.dnsproxyserver.server.dns.solver.SolverCache.lambda$handleRes$0(SolverCache.java:40) at com.mageddo.commons.caching.LruTTLCache.computeIfAbsent0(LruTTLCache.java:82) at com.mageddo.dnsproxyserver.server.dns.solver.SolverCache.handleRes(SolverCache.java:38) at com.mageddo.dnsproxyserver.server.dns.solver.SolverCache.handle(SolverCache.java:33) at com.mageddo.dnsproxyserver.server.dns.RequestHandlerDefault.solve(RequestHandlerDefault.java:46) at com.mageddo.dnsproxyserver.server.dns.RequestHandlerDefault.handle(RequestHandlerDefault.java:38) at com.mageddo.dnsproxyserver.server.dns.UDPServer.handle(UDPServer.java:54) at com.mageddo.dnsproxyserver.server.dns.UDPServer.lambda$start0$0(UDPServer.java:42) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:577) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) at java.base/java.lang.Thread.run(Thread.java:1589)
kerem commented 2026-02-26 04:34:10 +03:00
Author
Owner
Copy link

@mageddo commented on GitHub (Mar 22, 2023):

Fixed the NPE, but realized that there is some unexpected behavior happening, I'm seeing logs saying resolver took 40s to finish the process

10:22:52.760 [Thread-34      ] DEB c.m.d.server.dns.RequestHandlerDefault            l=48   m=solve                           status=solved, kind=udp, time=45857, res=google.com

I will take a deeper look at it.

<!-- gh-comment-id:1479567978 --> @mageddo commented on GitHub (Mar 22, 2023): Fixed the NPE, but realized that there is some unexpected behavior happening, I'm seeing logs saying resolver took 40s to finish the process ``` 10:22:52.760 [Thread-34 ] DEB c.m.d.server.dns.RequestHandlerDefault l=48 m=solve status=solved, kind=udp, time=45857, res=google.com ``` I will take a deeper look at it.
kerem commented 2026-02-26 04:34:10 +03:00
Author
Owner
Copy link

@mageddo commented on GitHub (Mar 23, 2023):

Hey, I've made an improvement on the cache parallelism, I think that is the most major offender to the performance. There is another improvement to do, let me know if it's enough for your use case.

Just released 3.15.3-snapshot with the improvement.

<!-- gh-comment-id:1480496405 --> @mageddo commented on GitHub (Mar 23, 2023): Hey, I've made an improvement on the cache parallelism, I think that is the most major offender to the performance. There is another improvement to do, let me know if it's enough for your use case. Just released [3.15.3-snapshot](https://github.com/mageddo/dns-proxy-server/releases/tag/3.15.3-snapshot) with the improvement.
kerem commented 2026-02-26 04:34:10 +03:00
Author
Owner
Copy link

@Sajito commented on GitHub (Mar 23, 2023):

Hey, just tried it and it looks really good. Thank you!

<!-- gh-comment-id:1480664636 --> @Sajito commented on GitHub (Mar 23, 2023): Hey, just tried it and it looks really good. Thank you!
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
gh-pages
develop
feat/138_2
feat/629
feat/594
5.9.0
5.9.0-snapshot
5.8.4
5.8.4-snapshot
5.8.3-snapshot
5.8.2-snapshot
5.8.1-snapshot
5.8.0-snapshot
5.7.0-snapshot
5.6.2-snapshot
5.6.1-snapshot
5.6.0-snapshot
5.5.1-snapshot
5.5.0-snapshot
5.4.0-snapshot
5.3.0-snapshot
5.2.0-snapshot
5.1.3-snapshot
5.1.2-snapshot
5.1.0-snapshot
5.0.5-snapshot
5.0.3-snapshot
5.0.2-snapshot
5.0.1-snapshot
5.0.0-snapshot
4.3.0-snapshot
4.2.0-snapshot
4.0.0
4.0.0-snapshot
3.32.7
3.32.7-snapshot
3.32.6
3.32.6-snapshot
3.32.5-snapshot
3.32.4
3.32.4-snapshot
3.32.3
3.32.3-snapshot
3.32.2-snapshot
3.32.1-snapshot
3.32.0-snapshot
3.31.1-snapshot
3.31.0-snapshot
3.30.5-snapshot
3.30.4
3.30.4-snapshot
3.30.3-snapshot
3.30.2-snapshot
3.30.1
3.30.1-snapshot
3.30.0-snapshot
3.29.0-snapshot
3.27.0
3.27.0-snapshot
3.26.0-snapshot
3.25.14
3.25.14-snapshot
3.25.13-snapshot
3.25.12-snapshot
3.25.11
3.25.11-snapshot
3.25.10
3.25.10-snapshot
3.25.9-snapshot
3.25.8-snapshot
3.25.7-snapshot
3.25.6-snapshot
3.25.4-snapshot
3.25.3-snapshot
3.25.2-snapshot
3.25.1-snapshot
3.25.0-snapshot
3.24.2
3.24.2-snapshot
3.24.1
3.24.1-snapshot
3.24.0-snapshot
3.23.0-snapshot
3.22.2-snapshot
3.22.3-snapshot
3.22.1-snapshot
3.21.3-snapshot
3.22.0-snapshot
3.21.2-snapshot
3.21.1-snapshot
3.20.0-snapshot
3.21.0-snapshot
3.19.7-snapshot
3.19.6-snapshot
3.19.5-snapshot
3.19.4-snapshot
3.19.3-snapshot
3.19.2-snapshot
3.19.1
3.19.1-snapshot
3.19.0
3.18.5-snapshot
3.18.4-snapshot
3.18.3-snapshot
3.18.2
3.18.2-snapshot
3.18.1-snapshot
3.18.0-snapshot
3.17.3-snapshot
3.17.2-snapshot
3.17.1-snapshot
3.17.0-snapshot
3.16.3-snapshot
3.16.2-snapshot
3.16.1-snapshot
3.16.0-snapshot
3.15.13-snapshot
3.15.12-snapshot
3.15.11-snapshot
3.15.10-snapshot
3.15.9-snapshot
3.15.8-snapshot
3.15.7-snapshot
3.15.6-snapshot
3.15.5-snapshot
3.15.4-snapshot
3.15.3-snapshot
3.15.2-snapshot
3.15.1-snapshot
3.15.0-snapshot
3.14.5
3.14.4
3.14.3
3.14.3-snapshot
3.14.2-snapshot
3.14.1-snapshot
3.14.0-snapshot
3.13.1
3.13.1-snapshot
3.13.0-snapshot
3.12.1
3.12.0
3.11.0
3.10.2-snapshot
3.10.3-snapshot
3.10.4-snapshot
3.10.5-snapshot
3.10.1-snapshot
3.9.2
3.9.1
3.9.0
3.8.1-last-version-with-quarkus
3.8.1
3.8.0
3.7.0
3.6.0
3.5.3
3.5.2
3.5.0
3.4.0-beta
3.3.0-beta
3.2.5-beta
3.2.4-beta
3.2.3-beta
3.2.2-beta
3.2.1-beta
3.2.0-beta
3.1.7-beta
3.1.6-beta
3.1.5-beta
3.1.4-beta
3.1.3-beta
3.1.2-beta
b-jre-8
3.1.1-beta
3.1.0-beta
3.0.4-beta
3.0.3-beta
3.0.2-beta
3.0.1-beta
v2-golang
2.19.5
2.19.4
2.19.3
2.19.2
2.19.1
2.19.0
2.18.7
2.18.6
2.18.5
2.18.4
2.18.3
2.18.2
2.18.1
2.18.0
2.17.4
2.17.3
2.17.2
2.17.1
2.17.0
2.16.0
2.15.0
2.14.6
2.14.5
2.14.4
2.14.2
2.14.1
2.14.0
2.13.2
2.13.1
2.13.0
2.12.0
2.11.0
2.10.4
2.10.3
2.10.2
2.10.1
2.10.0
2.9.1
2.9.0
2.8.0
2.7.0
2.6.1
2.6.0
2.5.4
2.5.3
2.5.2
2.5.1
2.5.0
2.4.1
2.4.0
2.3.3
2.2.3
2.2.2
2.2.1
2.2.0
2.1.8
2.1.7
2.1.6
2.1.5
2.1.2
2.1.1
2.1.0
2.0.21
2.0.20
2.0.19
2.0.18
2.0.17
2.0.16
2.0.9
2.0.5
2.0.4
v1-nodejs
1.8.1
1.8.0
1.7.7
1.7.6
1.7.5
1.7.4
1.7.3
1.7.2
1.7.1
1.7.0
1.6.9
1.6.8
1.6.7
1.6.6
1.6.5
1.6.4
1.6.3
1.6.2
1.6.1
1.6.0
1.5.0
1.4.0
1.3.5
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
peteris-version
1.1.4-peteris-version
1.2.0
1.1.3
1.1.2
1.1.1
1.1.0
1.0.1
1.0.0
Labels
Clear labels   
bug

   
confirmed

   
discussion

   
duplicate

   
enhancement

   
feature

   
feature-request

   
not-planned

   
pull-request

Mirrored from GitHub Pull Request

  
secondary-feature

   
stale

   
triage

   
waiting-feedback
No labels
bug
confirmed
discussion
duplicate
enhancement
feature
feature-request
not-planned
pull-request
secondary-feature
stale
triage
waiting-feedback
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/dns-proxy-server-mageddo#141
No description provided.