[GH-ISSUE #92] Possible bug in btDisable.Text = (IsDkimAgentTransportInstalled ? "Disable" : "Enable") #70

New issue

Closed

opened 2026-02-26 10:35:36 +03:00 by kerem · 3 comments

kerem commented

2026-02-26 10:35:36 +03:00

Owner

Originally created by @gogglespisano on GitHub (Jul 28, 2015).
Original GitHub issue: https://github.com/Pro/dkim-exchange/issues/92

In:
private void ExchangeTransportServiceWindows_Load(object sender, EventArgs e)
{
this.RefreshTransportServiceAgents();

        bool IsDkimAgentTransportInstalled = ExchangeServer.IsDkimAgentTransportInstalled();
        bool IsDkimAgentTransportEnabled = IsDkimAgentTransportInstalled && ExchangeServer.IsDkimAgentTransportEnabled();
        this.btDisable.Text = (IsDkimAgentTransportInstalled ? "Disable" : "Enable");
    }

Should it use Is...Enabled rather than Is...Installed?
this.btDisable.Text = (IsDkimAgentTransportInstalled ? "Disable" : "Enable");

It thinks it is enable when it's disabled and then you can't enable it from the UI.

Originally created by @gogglespisano on GitHub (Jul 28, 2015). Original GitHub issue: https://github.com/Pro/dkim-exchange/issues/92 In: private void ExchangeTransportServiceWindows_Load(object sender, EventArgs e) { this.RefreshTransportServiceAgents(); ``` bool IsDkimAgentTransportInstalled = ExchangeServer.IsDkimAgentTransportInstalled(); bool IsDkimAgentTransportEnabled = IsDkimAgentTransportInstalled && ExchangeServer.IsDkimAgentTransportEnabled(); this.btDisable.Text = (IsDkimAgentTransportInstalled ? "Disable" : "Enable"); } ``` Should it use Is...Enabled rather than Is...Installed? this.btDisable.Text = (IsDkimAgentTransportInstalled ? "Disable" : "Enable"); It thinks it is enable when it's disabled and then you can't enable it from the UI.

kerem closed this issue

2026-02-26 10:35:36 +03:00

kerem commented

2026-02-26 10:35:37 +03:00

Author

Owner

@AlexLaroche commented on GitHub (Jul 28, 2015):

8c0ed68aba

@AlexLaroche commented on GitHub (Jul 28, 2015): 8c0ed68aba7593408f4596613338a8ba0a662145

kerem commented

2026-02-26 10:35:37 +03:00

Author

Owner

@gogglespisano commented on GitHub (Aug 1, 2015):

This is now backwards. When it is enabled it should show "disable" as the choice and vice-versa.

@gogglespisano commented on GitHub (Aug 1, 2015): This is now backwards. When it is enabled it should show "disable" as the choice and vice-versa.

kerem commented

2026-02-26 10:35:37 +03:00

Author

Owner

@gogglespisano commented on GitHub (Aug 1, 2015):

Also, this code should be in RefreshTransportServiceAgents so that it updates when refreshed.

@gogglespisano commented on GitHub (Aug 1, 2015): Also, this code should be in RefreshTransportServiceAgents so that it updates when refreshed.