mirror of
https://github.com/HiddenClever/digitalocean-dns-sync.git
synced 2026-04-26 08:25:51 +03:00
[PR #13] [MERGED] Variable for db files + improved sync recognition. #15
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/digitalocean-dns-sync#15
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/HiddenClever/digitalocean-dns-sync/pull/13
Author: @macktic
Created: 4/22/2019
Status: ✅ Merged
Merged: 5/19/2019
Merged by: @ndjdev
Base:
master← Head:master📝 Commits (10+)
7423081Changed named files to variables from hard-coded.ba16787sort typoeba44f1sort typo5b96b2fsort typobd4a91cMerge branch 'variable_db' of github.com:macktic/digitalocean-dns-sync into variable_db9bdbc14Forced lowercase on AAAA for case-insensitive comparison.8ebda85Changed Readme for the new sync_dns_settings.py.example filef4bd203changed some formatting on MX to be recognised as already existing.02d08f0make sure "@" translates to domain.ef29cdcRevert "make sure "@" translates to domain."📊 Changes
3 files changed (+33 additions, -24 deletions)
View changed files
📝
README.md(+11 -13)📝
sync_dns.py(+14 -11)➕
sync_dns_settings.py.example(+8 -0)📄 Description
I changed the hard-coded named db files to variables as my files where in a different location.
Tidied up the MX records as they were not being recognised as the same and recreated every time.
Made the AAAA records case insensitive, this was a big one for me as all AAAA records where deleted and recreated every time, which lead to a lot of random errors with the API
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.