[PR #477] [MERGED] refactor(terminal): centralize log viewer state with Zustand #494

New issue

Closed

opened 2026-03-03 11:30:14 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 11:30:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dflow-sh/dflow/pull/477
Author: @manikanta9176
Created: 10/14/2025
Status: ✅ Merged
Merged: 10/14/2025
Merged by: @manikanta9176

Base: main ← Head: feat/preserve-terminal-logs

📝 Commits (1)

62e6d13 refactor(terminal): centralize log viewer state with Zustand

📊 Changes

7 files changed (+420 additions, -164 deletions)

View changed files

📝 package.json (+2 -1)
📝 pnpm-lock.yaml (+27 -0)
📝 src/components/bubble/TerminalPanel.tsx (+2 -2)
📝 src/components/bubble/XTermLogViewer.tsx (+59 -157)
📝 src/components/ui/alert-dialog.tsx (+2 -2)
📝 src/components/ui/dialog.tsx (+2 -2)
➕ src/stores/useTerminalStore.ts (+326 -0)

📄 Description

Migrated XTermLogViewer's connection and log state to a new Zustand store.
Centralizes server connection status and log history, improving scalability and maintainability.
Removes direct EventSource management from the component, simplifying its logic.
Increased z-index for AlertDialog and Dialog components to prevent layering issues.
Adjusted TerminalPanel resize handle dimensions for improved usability.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dflow-sh/dflow/pull/477 **Author:** [@manikanta9176](https://github.com/manikanta9176) **Created:** 10/14/2025 **Status:** ✅ Merged **Merged:** 10/14/2025 **Merged by:** [@manikanta9176](https://github.com/manikanta9176) **Base:** `main` ← **Head:** `feat/preserve-terminal-logs` --- ### 📝 Commits (1) - [`62e6d13`](https://github.com/dflow-sh/dflow/commit/62e6d1361bc4368796c0133b28011d1ca6edf71a) refactor(terminal): centralize log viewer state with Zustand ### 📊 Changes **7 files changed** (+420 additions, -164 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+2 -1) 📝 `pnpm-lock.yaml` (+27 -0) 📝 `src/components/bubble/TerminalPanel.tsx` (+2 -2) 📝 `src/components/bubble/XTermLogViewer.tsx` (+59 -157) 📝 `src/components/ui/alert-dialog.tsx` (+2 -2) 📝 `src/components/ui/dialog.tsx` (+2 -2) ➕ `src/stores/useTerminalStore.ts` (+326 -0) </details> ### 📄 Description - Migrated XTermLogViewer's connection and log state to a new Zustand store. - Centralizes server connection status and log history, improving scalability and maintainability. - Removes direct EventSource management from the component, simplifying its logic. - Increased z-index for AlertDialog and Dialog components to prevent layering issues. - Adjusted TerminalPanel resize handle dimensions for improved usability. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>