[PR #459] [MERGED] fix: prevent provider field reset when updating unrelated service fields #486

New issue

Closed

opened 2026-03-03 11:30:12 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 11:30:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dflow-sh/dflow/pull/459
Author: @pespantelis
Created: 10/4/2025
Status: ✅ Merged
Merged: 10/6/2025
Merged by: @pavanbhaskardev

Base: main ← Head: fix-github-provider-reset

📝 Commits (1)

11ca664 fix: prevent provider field reset when updating unrelated service fields

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 src/actions/service/index.ts (+3 -1)

📄 Description

Issue

The provider field was being reset to null whenever updating service fields from tabs other than the General tab (e.g., Environment or Switch Service settings). This caused to lose the provider configuration when saving environment variables or switching services between projects.

To reproduce

Go to a service's General tab
Set up the GitHub provider, using automatic deployment
Save the General settings
Navigate to Environment tab
Add/modify environment variables
Save the Environment settings
Navigate back to General tab

💥 The GitHub provider setting has been reset to "without automatic deployment".

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dflow-sh/dflow/pull/459 **Author:** [@pespantelis](https://github.com/pespantelis) **Created:** 10/4/2025 **Status:** ✅ Merged **Merged:** 10/6/2025 **Merged by:** [@pavanbhaskardev](https://github.com/pavanbhaskardev) **Base:** `main` ← **Head:** `fix-github-provider-reset` --- ### 📝 Commits (1) - [`11ca664`](https://github.com/dflow-sh/dflow/commit/11ca6645a4a6be3126dc2d3ea8ec4e6d93ca697f) fix: prevent provider field reset when updating unrelated service fields ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/actions/service/index.ts` (+3 -1) </details> ### 📄 Description ### Issue The `provider` field was being reset to `null` whenever updating service fields from tabs other than the General tab (e.g., Environment or Switch Service settings). This caused to lose the provider configuration when saving environment variables or switching services between projects. ### To reproduce 1. Go to a service's General tab 2. Set up the GitHub provider, using automatic deployment 3. Save the General settings 4. Navigate to Environment tab 5. Add/modify environment variables 6. Save the Environment settings 7. Navigate back to General tab 💥 The GitHub provider setting has been reset to "without automatic deployment". --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>