[PR #460] [MERGED] fix(ui): use consistent layout for GitHub deployment options #483

New issue

Closed

opened 2026-03-03 11:30:11 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 11:30:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dflow-sh/dflow/pull/460
Author: @pespantelis
Created: 10/4/2025
Status: ✅ Merged
Merged: 10/6/2025
Merged by: @pavanbhaskardev

Base: main ← Head: fix-github-provider-layout

📝 Commits (3)

fe54725 fix: add negative margin to SidebarToggleButton to prevent height expansion
1997f77 chore: use the same layout with manual deployment
50ba39a chore: reorder port and build path fields

📊 Changes

4 files changed (+150 additions, -154 deletions)

View changed files

📝 src/components/SidebarToggleButton.tsx (+1 -1)
📝 src/components/service/DockerForm.tsx (+1 -1)
📝 src/components/service/VariablesForm.tsx (+1 -1)
📝 src/components/service/git/GithubForm.tsx (+147 -151)

📄 Description

This PR improves the UI consistency of the GitHub deployment options. The SidebarToggleButton alignment fix (negative margin) has been validated across all usage contexts and I think that provides better visual alignment.

Before:

After:

Note for reviewers: Please review with "Ignore whitespace" option enabled to focus on the actual code changes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dflow-sh/dflow/pull/460 **Author:** [@pespantelis](https://github.com/pespantelis) **Created:** 10/4/2025 **Status:** ✅ Merged **Merged:** 10/6/2025 **Merged by:** [@pavanbhaskardev](https://github.com/pavanbhaskardev) **Base:** `main` ← **Head:** `fix-github-provider-layout` --- ### 📝 Commits (3) - [`fe54725`](https://github.com/dflow-sh/dflow/commit/fe547255456a330eea4c26c2a7510d5089c4f273) fix: add negative margin to SidebarToggleButton to prevent height expansion - [`1997f77`](https://github.com/dflow-sh/dflow/commit/1997f7725b4f2a0f08192a6d995084621ddaa5c4) chore: use the same layout with manual deployment - [`50ba39a`](https://github.com/dflow-sh/dflow/commit/50ba39a76c5710947efd9c54074cd8ce914ea8bb) chore: reorder port and build path fields ### 📊 Changes **4 files changed** (+150 additions, -154 deletions) <details> <summary>View changed files</summary> 📝 `src/components/SidebarToggleButton.tsx` (+1 -1) 📝 `src/components/service/DockerForm.tsx` (+1 -1) 📝 `src/components/service/VariablesForm.tsx` (+1 -1) 📝 `src/components/service/git/GithubForm.tsx` (+147 -151) </details> ### 📄 Description This PR improves the UI consistency of the GitHub deployment options. The `SidebarToggleButton` alignment fix (negative margin) has been validated across all usage contexts and I think that provides better visual alignment. Before: ![before](https://github.com/user-attachments/assets/a7470eb1-a76e-4c74-95ba-880c7933d743) After: ![after](https://github.com/user-attachments/assets/8c2ebff9-9269-4a22-b3e9-846053c673ba) > **Note for reviewers:** Please review with "Ignore whitespace" option enabled to focus on the actual code changes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>