[PR #268] [MERGED] Feat volumes jm #405

New issue

Closed

opened 2026-03-03 11:29:48 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 11:29:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dflow-sh/dflow/pull/268
Author: @jagadeesh507
Created: 6/25/2025
Status: ✅ Merged
Merged: 6/25/2025
Merged by: @jagadeesh507

Base: main ← Head: feat-volumes-jm

📝 Commits (10+)

bed9d6f chore: add volumes field to Template collection
23da4f4 chore: add Volume option to ChooseService component
7bde544 chore: enhance EditServiceName component with type handling and context menu support
883cbd0 chore: add onCloseAutoFocus handler to DialogContent in EditServiceName component
450f82b chore: add volumes property to ServiceNode in convertToGraph function
a4240a3 feat: add volume management functionality to services with validation
a278638 feat: implement volume management functionality including creation, mounting, and unmounting
4790dba feat: enhance volume management by adding JSON parsing for volume listing and implementing update volumes queue
7f75469 feat: add update volumes functionality with validation and UI integration
dbee77a feat: add 'Volumes' tab to service layout for improved navigation

📊 Changes

27 files changed (+1131 additions, -141 deletions)

View changed files

📝 src/actions/service/index.ts (+47 -44)
📝 src/actions/service/validator.ts (+13 -0)
📝 src/actions/templates/index.ts (+6 -0)
📝 src/actions/templates/validator.ts (+9 -0)
📝 src/app/(frontend)/(dashboard)/[organisation]/dashboard/project/[id]/service/[serviceId]/layout.client.tsx (+2 -0)
📝 src/app/(frontend)/(dashboard)/[organisation]/dashboard/project/[id]/service/[serviceId]/page.tsx (+3 -1)
📝 src/components/reactflow/CustomNodes/index.tsx (+66 -42)
📝 src/components/reactflow/types.ts (+6 -0)
📝 src/components/reactflow/utils/convertServicesToNodes.ts (+1 -0)
➕ src/components/service/VolumesForm.tsx (+198 -0)
➕ src/components/templates/compose/AddVolumeToService.tsx (+284 -0)
📝 src/components/templates/compose/ChooseService.tsx (+46 -4)
📝 src/components/templates/compose/ContextMenu.tsx (+36 -20)
📝 src/components/templates/compose/EditServiceName.tsx (+28 -14)
📝 src/components/templates/compose/UpdateServiceDetails.tsx (+1 -0)
📝 src/components/templates/compose/types.ts (+52 -0)
📝 src/lib/dokku/index.ts (+8 -0)
➕ src/lib/dokku/volumes/list.ts (+15 -0)
➕ src/lib/dokku/volumes/mount.ts (+26 -0)
➕ src/lib/dokku/volumes/unmount.ts (+24 -0)

...and 7 more files

📄 Description

Add volumes ui to template.
dokku volumes commands to mount ,list and unmount.
queue to add and delete volumes.
Display volumes in individual service tab

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dflow-sh/dflow/pull/268 **Author:** [@jagadeesh507](https://github.com/jagadeesh507) **Created:** 6/25/2025 **Status:** ✅ Merged **Merged:** 6/25/2025 **Merged by:** [@jagadeesh507](https://github.com/jagadeesh507) **Base:** `main` ← **Head:** `feat-volumes-jm` --- ### 📝 Commits (10+) - [`bed9d6f`](https://github.com/dflow-sh/dflow/commit/bed9d6f39f5be0a5017e65f716d049f6e2f66198) chore: add volumes field to Template collection - [`23da4f4`](https://github.com/dflow-sh/dflow/commit/23da4f4980e808208f15e7cdab13a8661fea596a) chore: add Volume option to ChooseService component - [`7bde544`](https://github.com/dflow-sh/dflow/commit/7bde5449c424e9c8a33ba23e1f098ce1246fd300) chore: enhance EditServiceName component with type handling and context menu support - [`883cbd0`](https://github.com/dflow-sh/dflow/commit/883cbd06c406bcbf52f9483b48495c643650542b) chore: add onCloseAutoFocus handler to DialogContent in EditServiceName component - [`450f82b`](https://github.com/dflow-sh/dflow/commit/450f82bf40785e7d850d975fa93c5c33350f524f) chore: add volumes property to ServiceNode in convertToGraph function - [`a4240a3`](https://github.com/dflow-sh/dflow/commit/a4240a300d577d812579a4b9b097d55e1f3807f7) feat: add volume management functionality to services with validation - [`a278638`](https://github.com/dflow-sh/dflow/commit/a27863866b8057a14335c0ad8700d92a4f5d5cdc) feat: implement volume management functionality including creation, mounting, and unmounting - [`4790dba`](https://github.com/dflow-sh/dflow/commit/4790dba3b2284b0838d1d3f20fa65faa31d70d05) feat: enhance volume management by adding JSON parsing for volume listing and implementing update volumes queue - [`7f75469`](https://github.com/dflow-sh/dflow/commit/7f7546911618ae0104897e4ceeab5a4b627d1938) feat: add update volumes functionality with validation and UI integration - [`dbee77a`](https://github.com/dflow-sh/dflow/commit/dbee77ab20fe617908b562dbd1a5f2b00c88cc87) feat: add 'Volumes' tab to service layout for improved navigation ### 📊 Changes **27 files changed** (+1131 additions, -141 deletions) <details> <summary>View changed files</summary> 📝 `src/actions/service/index.ts` (+47 -44) 📝 `src/actions/service/validator.ts` (+13 -0) 📝 `src/actions/templates/index.ts` (+6 -0) 📝 `src/actions/templates/validator.ts` (+9 -0) 📝 `src/app/(frontend)/(dashboard)/[organisation]/dashboard/project/[id]/service/[serviceId]/layout.client.tsx` (+2 -0) 📝 `src/app/(frontend)/(dashboard)/[organisation]/dashboard/project/[id]/service/[serviceId]/page.tsx` (+3 -1) 📝 `src/components/reactflow/CustomNodes/index.tsx` (+66 -42) 📝 `src/components/reactflow/types.ts` (+6 -0) 📝 `src/components/reactflow/utils/convertServicesToNodes.ts` (+1 -0) ➕ `src/components/service/VolumesForm.tsx` (+198 -0) ➕ `src/components/templates/compose/AddVolumeToService.tsx` (+284 -0) 📝 `src/components/templates/compose/ChooseService.tsx` (+46 -4) 📝 `src/components/templates/compose/ContextMenu.tsx` (+36 -20) 📝 `src/components/templates/compose/EditServiceName.tsx` (+28 -14) 📝 `src/components/templates/compose/UpdateServiceDetails.tsx` (+1 -0) 📝 `src/components/templates/compose/types.ts` (+52 -0) 📝 `src/lib/dokku/index.ts` (+8 -0) ➕ `src/lib/dokku/volumes/list.ts` (+15 -0) ➕ `src/lib/dokku/volumes/mount.ts` (+26 -0) ➕ `src/lib/dokku/volumes/unmount.ts` (+24 -0) _...and 7 more files_ </details> ### 📄 Description - [x] Add volumes ui to template. - [x] dokku volumes commands to `mount` ,`list` and `unmount`. - [x] queue to add and delete volumes. - [x] Display volumes in individual service tab --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>