[PR #674] [MERGED] Fix : create empty setting entry for carddav server #972

Closed
opened 2026-02-25 21:36:49 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/674
Author: @ElvisAns
Created: 2/18/2023
Status: Merged
Merged: 3/24/2023
Merged by: @marclaporte

Base: masterHead: fix_carddav_issue_not_workin


📝 Commits (1)

  • 8301978 fix : create empty setting entry for carddav server

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 modules/carddav_contacts/modules.php (+4 -0)

📄 Description

Pullrequest

The CardDav module doesn't allow users to save contacts in a given address book

Issues

Checklist

  • Config Update

How2Test

  • Activate the carddav module in the hm3.ini file by adding modules[]=carddav_contacts
  • Move the carddav.ini file from modules/carddav_contacts/carddav.ini to your app_data_dir defined in your hm3.ini
  • Generate the production site

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/674 **Author:** [@ElvisAns](https://github.com/ElvisAns) **Created:** 2/18/2023 **Status:** ✅ Merged **Merged:** 3/24/2023 **Merged by:** [@marclaporte](https://github.com/marclaporte) **Base:** `master` ← **Head:** `fix_carddav_issue_not_workin` --- ### 📝 Commits (1) - [`8301978`](https://github.com/cypht-org/cypht/commit/8301978d888b33723b2af86adcc2d58d90f70f6e) fix : create empty setting entry for carddav server ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `modules/carddav_contacts/modules.php` (+4 -0) </details> ### 📄 Description ## Pullrequest <!-- Describe the Pullrequest. --> The CardDav module doesn't allow users to save contacts in a given address book ### Issues - [X] fixes #640 ### Checklist <!-- Anything important to be thought of when deploying? --> - [X] Config Update ### How2Test <!-- Give a detailed description of how to test your PR and confirm it is working as expected. --> <!-- Maintainers will check the Tests --> - [X] Activate the carddav module in the `hm3.ini` file by adding modules[]=carddav_contacts - [X] Move the carddav.ini file from `modules/carddav_contacts/carddav.ini` to your `app_data_dir` defined in your `hm3.ini` - [X] Generate the production site --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 21:36:49 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#972
No description provided.