[PR #667] [MERGED] [Feat] Make number of Google contacts configurable #970

Closed
opened 2026-02-25 21:36:49 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/667
Author: @henochit
Created: 1/21/2023
Status: Merged
Merged: 4/20/2023
Merged by: @marclaporte

Base: masterHead: feat/add_max_google_contact_conf


📝 Commits (6)

  • 9c99261 Feat: implement Hm_output_max_google_contacts_number
  • 492421d Feat: set max google import constant
  • 24b4bfe Feat: add google max contact handler
  • a5c4ef4 Refactor: replace max google contacts number by the constant
  • f98ca5d Refactor: use the default value of max google contact
  • 08bf72b Fix: use configured variable on fetch google contact

📊 Changes

6 files changed (+54 additions, -3 deletions)

View changed files

📝 modules/core/modules.php (+1 -0)
📝 modules/core/site.js (+5 -0)
📝 modules/gmail_contacts/modules.php (+11 -3)
📝 modules/imap/handler_modules.php (+13 -0)
📝 modules/imap/output_modules.php (+21 -0)
📝 modules/imap/setup.php (+3 -0)

📄 Description

Pullrequest

Make number of Google contacts configurable, now hard-coded to 500.

Issues

Checklist

  • None

How2Test

  • Configure max number of google contact
  • Try to import contact from google

Todo

  • None

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/667 **Author:** [@henochit](https://github.com/henochit) **Created:** 1/21/2023 **Status:** ✅ Merged **Merged:** 4/20/2023 **Merged by:** [@marclaporte](https://github.com/marclaporte) **Base:** `master` ← **Head:** `feat/add_max_google_contact_conf` --- ### 📝 Commits (6) - [`9c99261`](https://github.com/cypht-org/cypht/commit/9c992614846c3569b80b12809f177d718b5f67a3) Feat: implement Hm_output_max_google_contacts_number - [`492421d`](https://github.com/cypht-org/cypht/commit/492421df5aad76886c3464ff297b5587732ed5fb) Feat: set max google import constant - [`24b4bfe`](https://github.com/cypht-org/cypht/commit/24b4bfeae9f75558c49d62e9460ec1877026108f) Feat: add google max contact handler - [`a5c4ef4`](https://github.com/cypht-org/cypht/commit/a5c4ef4891b30b1baead0c5884a241a13c9266b5) Refactor: replace max google contacts number by the constant - [`f98ca5d`](https://github.com/cypht-org/cypht/commit/f98ca5d9ba9996486c49e209391a613dae951338) Refactor: use the default value of max google contact - [`08bf72b`](https://github.com/cypht-org/cypht/commit/08bf72b4fd4a13a58364050166f904d526a3308b) Fix: use configured variable on fetch google contact ### 📊 Changes **6 files changed** (+54 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `modules/core/modules.php` (+1 -0) 📝 `modules/core/site.js` (+5 -0) 📝 `modules/gmail_contacts/modules.php` (+11 -3) 📝 `modules/imap/handler_modules.php` (+13 -0) 📝 `modules/imap/output_modules.php` (+21 -0) 📝 `modules/imap/setup.php` (+3 -0) </details> ### 📄 Description ## Pullrequest <!-- Describe the Pullrequest. --> Make number of Google contacts configurable, now hard-coded to 500. ### Issues <!-- Which Issues does this fix, which are related? - fixes #XXX - relates #XXX --> - [gitter message](https://gitter.im/cypht-org/community?at=61ba7ee19a9ec834fbcfa74a) ### Checklist <!-- Anything important to be thought of when deploying? - [ ] Config Update - [ ] Breaking/critical change --> - [X] None ### How2Test <!-- Give a detailed description how to test your PR and confirm it is working as expected. --> <!-- Maintainers will check the Tests - [ ] Test1 - [ ] Test2 --> - [X] Configure max number of google contact - [X] Try to import contact from google ### Todo <!-- In case some parts are still missing, list them here. - [ ] Changelog --> - [X] None --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 21:36:49 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#970
No description provided.