[PR #665] [MERGED] Add a way to customize the icons color with the fill attribute for svg icons #967

New issue

Closed

opened 2026-02-25 21:36:48 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:36:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/665
Author: @johnsantosDev
Created: 1/16/2023
Status: ✅ Merged
Merged: 1/20/2023
Merged by: @marclaporte

Base: master ← Head: fill-attribute-svg

📝 Commits (1)

d38ad01 Add a fill attribute for svg icons

📊 Changes

1 file changed (+9 additions, -0 deletions)

View changed files

📝 lib/output.php (+9 -0)

📄 Description

Pullrequest

When a user want to customize the icons color according to the theme change, instead of Hm_Image_Sources::$home bata we can now use Hm_Image_Sources::home("blue") or Hm_Image_Sources::home("#1a1a1a") or Hm_Image_Sources::home($icon_color_variable) to determine the color.

Issues

UI issue related to the icons when the user uses differents themes

Checklist

None

How2Test

eg :

None

Todo

None

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/665 **Author:** [@johnsantosDev](https://github.com/johnsantosDev) **Created:** 1/16/2023 **Status:** ✅ Merged **Merged:** 1/20/2023 **Merged by:** [@marclaporte](https://github.com/marclaporte) **Base:** `master` ← **Head:** `fill-attribute-svg` --- ### 📝 Commits (1) - [`d38ad01`](https://github.com/cypht-org/cypht/commit/d38ad01f2a33ac52f394021a9290fce27fb324c0) Add a fill attribute for svg icons ### 📊 Changes **1 file changed** (+9 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `lib/output.php` (+9 -0) </details> ### 📄 Description ## Pullrequest When a user want to customize the icons color according to the theme change, instead of Hm_Image_Sources::$home bata we can now use Hm_Image_Sources::home("blue") or Hm_Image_Sources::home("#1a1a1a") or Hm_Image_Sources::home($icon_color_variable) to determine the color. ### Issues UI issue related to the icons when the user uses differents themes ### Checklist  - [X] None ### How2Test   eg : ![image](https://user-images.githubusercontent.com/92297941/212768695-18a8d90a-a615-46e3-b5e2-44067ce49714.png) ![image](https://user-images.githubusercontent.com/92297941/212768605-f4331853-ad94-4e9c-a9d6-7c18843f3077.png) - [X] None ### Todo  - [X] None --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>