[PR #649] [CLOSED] Icons - theme compatibility - use Bootstrap icons instead of svg ones #956

New issue

Closed

opened 2026-02-25 21:36:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:36:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/649
Author: @johnsantosDev
Created: 10/30/2022
Status: ❌ Closed

Base: master ← Head: theme-compatibility-with-icons

📄 Description

Pullrequest

PROBLEM & LINK TO TASK DESCRIPTION

https://avan.tech/item41850-Cypht-in-Tiki-Change-icon-colors-by-inserting-a-fill-attribute-into-the-SVGs
The mission is to make Cypht icons look acceptable with all the Tiki themes, using the method suggested by Jason (or propose better).
After checking about this issue, I found that the better way is to allow using the existing bootstrap icons instead of SVG ones, why? because they're compatible with all all themes.
I am making it optional so that user can decide to either keep using svg icons or switch to bootstrap icons.

; Bootstrap Icons
; ---------------
; Use Bootrap icons instead of SVG ones on menu icons
default_icons_to_bootstrap_icons=y

Issues

Icons color impactibility with the existing themes

Checklist

With this change, COMPOSER was updated, here's the version "twbs/bootstrap-icons": "^1.9"

How2Test

You need to run composer update in order to make tests
For your test, update the file hm3.ini by adding the line default_icons_to_bootstrap_icons=y

Todo

None

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/649 **Author:** [@johnsantosDev](https://github.com/johnsantosDev) **Created:** 10/30/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `theme-compatibility-with-icons` --- ### 📄 Description ## Pullrequest PROBLEM & LINK TO TASK DESCRIPTION ![image](https://user-images.githubusercontent.com/92297941/198905761-94e96906-656b-47b6-8304-e3ec5734d898.png) https://avan.tech/item41850-Cypht-in-Tiki-Change-icon-colors-by-inserting-a-fill-attribute-into-the-SVGs The mission is to make Cypht icons look acceptable with all the Tiki themes, using the method suggested by Jason (or propose better). After checking about this issue, I found that the better way is to allow using the existing bootstrap icons instead of SVG ones, why? because they're compatible with all all themes. I am making it optional so that user can decide to either keep using svg icons or switch to bootstrap icons. ``` ; Bootstrap Icons ; --------------- ; Use Bootrap icons instead of SVG ones on menu icons default_icons_to_bootstrap_icons=y ``` ### Issues Icons color impactibility with the existing themes ### Checklist With this change, COMPOSER was updated, here's the version `"twbs/bootstrap-icons": "^1.9"` ### How2Test You need to run composer update in order to make tests For your test, update the file hm3.ini by adding the line `default_icons_to_bootstrap_icons=y` ### Todo  - [X] None --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>