[PR #648] [CLOSED] improve compatibility with stalwart-jmap #955

New issue

Closed

opened 2026-02-25 21:36:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:36:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/648
Author: @landryb
Created: 10/30/2022
Status: ❌ Closed

Base: master ← Head: fix/stalwart-jmap

📝 Commits (4)

9a18d35 check that messageId/from/to are arrays before imploding/combining them
9abb224 set api_url to the full url that was returned in apiUrl
f3811f0 apparently jmap spec says that an account is primary in the 'primaryAccount' toplevel key
15a5a46 unescape slashes when encoding the JMAP methods

📊 Changes

1 file changed (+8 additions, -7 deletions)

View changed files

📝 modules/imap/hm-jmap.php (+8 -7)

📄 Description

Pullrequest

work in progress, fixing the issues i described in #180. With that PR i can list mails in the INBOX, but clicking on a mail sometimes crashes stalwart-jmap. Still digging..

apiUrl is a full url, the current code does something weird
don't escape forward slashes when sending json, otherwise it returns a 400 code with urn:ietf:params:jmap:error:notRequest
messageId/From/To might be null/empty
isPrimary isnt mentioned anymore in https://jmap.io/spec-core.html, primaryAccount should be used

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/648 **Author:** [@landryb](https://github.com/landryb) **Created:** 10/30/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/stalwart-jmap` --- ### 📝 Commits (4) - [`9a18d35`](https://github.com/cypht-org/cypht/commit/9a18d35fc28d26950c7c380f3f52212e9b322ca8) check that messageId/from/to are arrays before imploding/combining them - [`9abb224`](https://github.com/cypht-org/cypht/commit/9abb2245cbeb567941d273abadbf51f860fd2224) set api_url to the full url that was returned in apiUrl - [`f3811f0`](https://github.com/cypht-org/cypht/commit/f3811f09877b295782cbe2f85c1ed1617f9769b8) apparently jmap spec says that an account is primary in the 'primaryAccount' toplevel key - [`15a5a46`](https://github.com/cypht-org/cypht/commit/15a5a463d3ba637a9c7996a9f6029cd50d1fa2da) unescape slashes when encoding the JMAP methods ### 📊 Changes **1 file changed** (+8 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `modules/imap/hm-jmap.php` (+8 -7) </details> ### 📄 Description ## Pullrequest work in progress, fixing the issues i described in #180. With that PR i can list mails in the INBOX, but clicking on a mail sometimes crashes stalwart-jmap. Still digging.. - `apiUrl` is a full url, the current code does something weird - don't escape forward slashes when sending json, otherwise it returns a 400 code with `urn:ietf:params:jmap:error:notRequest` - `messageId`/`From`/`To` might be null/empty - `isPrimary` isnt mentioned anymore in https://jmap.io/spec-core.html, `primaryAccount` should be used --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>