[PR #630] [MERGED] ability to specify sieve client externally, so integrating apps can use a different factory #941

New issue

Closed

opened 2026-02-25 21:36:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:36:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/630
Author: @kroky
Created: 9/30/2022
Status: ✅ Merged
Merged: 10/10/2022
Merged by: @jasonmunro

Base: master ← Head: feature/sieve-client-factory

📝 Commits (2)

8fe7f2d ability to specify sieve client externally, so integrating apps can use a different factory
c0d6e38 fix array_search calls comparison when blocked_senders was the first element in the sieve scripts array; move sieve_filters_enabled handler code to sievefilters module and reuse the client availability to check if target mailbox supports sieve

📊 Changes

4 files changed (+105 additions, -65 deletions)

View changed files

📝 modules/imap/handler_modules.php (+0 -7)
📝 modules/imap/output_modules.php (+2 -2)
📝 modules/sievefilters/modules.php (+100 -56)
📝 modules/sievefilters/setup.php (+3 -0)

📄 Description

Abstract the way sieve client is constructed, so we can use a different client in Tiki-Cypht integration - we need an internal custom one that saves filters in Tiki, so we can process them later in Tiki - this is in the case when IMAP server doesn't support sieve or we need extra functionality not supported in sieve.
Context: https://gitlab.com/tikiwiki/tiki/-/merge_requests/1837

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/630 **Author:** [@kroky](https://github.com/kroky) **Created:** 9/30/2022 **Status:** ✅ Merged **Merged:** 10/10/2022 **Merged by:** [@jasonmunro](https://github.com/jasonmunro) **Base:** `master` ← **Head:** `feature/sieve-client-factory` --- ### 📝 Commits (2) - [`8fe7f2d`](https://github.com/cypht-org/cypht/commit/8fe7f2d966cddb53b34245697a6f25fb3052f5e8) ability to specify sieve client externally, so integrating apps can use a different factory - [`c0d6e38`](https://github.com/cypht-org/cypht/commit/c0d6e38797c4fc62646e30ffe349dfc0f0ff87e0) fix array_search calls comparison when blocked_senders was the first element in the sieve scripts array; move sieve_filters_enabled handler code to sievefilters module and reuse the client availability to check if target mailbox supports sieve ### 📊 Changes **4 files changed** (+105 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `modules/imap/handler_modules.php` (+0 -7) 📝 `modules/imap/output_modules.php` (+2 -2) 📝 `modules/sievefilters/modules.php` (+100 -56) 📝 `modules/sievefilters/setup.php` (+3 -0) </details> ### 📄 Description Abstract the way sieve client is constructed, so we can use a different client in Tiki-Cypht integration - we need an internal custom one that saves filters in Tiki, so we can process them later in Tiki - this is in the case when IMAP server doesn't support sieve or we need extra functionality not supported in sieve. Context: https://gitlab.com/tikiwiki/tiki/-/merge_requests/1837 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>