[PR #607] [MERGED] Fix mobile look for sieve filter #922

Closed
opened 2026-02-25 21:36:39 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/607
Author: @ElvisAns
Created: 8/29/2022
Status: Merged
Merged: 9/13/2022
Merged by: @jasonmunro

Base: masterHead: Fix-mobile-look-for-sieve-filter


📝 Commits (10+)

  • 775a475 Rework the css for add script window
  • 819eeef Rework the css for add filter window
  • 38ca649 Formated the code and added several style for condition table rendering
  • 972fac0 Formated the code and added several style for actions table rendering
  • 38efce4 Merge branch 'master' of https://github.com/ElvisAns/cypht into Fix-mobile-look-for-sieve-filter
  • ce2c4f9 Formated the code
  • 33be45f Add margin top for the actions & filter container
  • 7a78342 Left align table content
  • 1c51b17 Better style the close button
  • a6d277c Add more space for delete column

📊 Changes

3 files changed (+210 additions, -68 deletions)

View changed files

📝 modules/sievefilters/modules.php (+12 -12)
📝 modules/sievefilters/site.css (+195 -53)
📝 modules/sievefilters/site.js (+3 -3)

📄 Description

Pullrequest

Issues

  • The sieve filter page was not looking good on mobile devices

Checklist

  • To make sure the new styles are applied run the config_gen.php file (eg . php ./scripts/config_gen.php)

How2Test

  • Pull this branch, apply the config gen then navigate where you add filters/scripts for your emails
  • Make sure you have configured sieve filters when adding the mail

How does the solution looks like

Todo

  • Other things related to the whole web app look and feel eg. the login page...

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/607 **Author:** [@ElvisAns](https://github.com/ElvisAns) **Created:** 8/29/2022 **Status:** ✅ Merged **Merged:** 9/13/2022 **Merged by:** [@jasonmunro](https://github.com/jasonmunro) **Base:** `master` ← **Head:** `Fix-mobile-look-for-sieve-filter` --- ### 📝 Commits (10+) - [`775a475`](https://github.com/cypht-org/cypht/commit/775a4755d47177d3d2ad240ab817f55793f0b03c) Rework the css for add script window - [`819eeef`](https://github.com/cypht-org/cypht/commit/819eeef6158027225973021528fafc0aba447450) Rework the css for add filter window - [`38ca649`](https://github.com/cypht-org/cypht/commit/38ca6494432d1b615fe7be3a7c804f8a606f58fe) Formated the code and added several style for condition table rendering - [`972fac0`](https://github.com/cypht-org/cypht/commit/972fac03f76def1aa099aa2471280fb8ca2144eb) Formated the code and added several style for actions table rendering - [`38efce4`](https://github.com/cypht-org/cypht/commit/38efce460ae9265e206e5077cbee95a45c375c3a) Merge branch 'master' of https://github.com/ElvisAns/cypht into Fix-mobile-look-for-sieve-filter - [`ce2c4f9`](https://github.com/cypht-org/cypht/commit/ce2c4f930d4cbae4b5c2a91821c4438f0af00c99) Formated the code - [`33be45f`](https://github.com/cypht-org/cypht/commit/33be45f04eaf56a9cbbaa165f27b6c5eb4a9a67e) Add margin top for the actions & filter container - [`7a78342`](https://github.com/cypht-org/cypht/commit/7a7834204de1cb0d41e37b2ba67aa4b4c8afa374) Left align table content - [`1c51b17`](https://github.com/cypht-org/cypht/commit/1c51b1758866c030a6d5aeb59e4333accbe61b3c) Better style the close button - [`a6d277c`](https://github.com/cypht-org/cypht/commit/a6d277c50ab6acd7856641292c4ea6eeac834e0f) Add more space for delete column ### 📊 Changes **3 files changed** (+210 additions, -68 deletions) <details> <summary>View changed files</summary> 📝 `modules/sievefilters/modules.php` (+12 -12) 📝 `modules/sievefilters/site.css` (+195 -53) 📝 `modules/sievefilters/site.js` (+3 -3) </details> ### 📄 Description ## Pullrequest <!-- Describe the Pullrequest. --> ### Issues - The sieve filter page was not looking good on mobile devices <img src="https://user-images.githubusercontent.com/35831811/187229982-ad75d79f-eddc-40a2-bdd8-d7c6db2ebe69.png" height="550px"> ### Checklist - To make sure the new styles are applied run the config_gen.php file (eg . `php ./scripts/config_gen.php`) ### How2Test - Pull this branch, apply the config gen then navigate where you add filters/scripts for your emails - Make sure you have configured sieve filters when adding the mail ### How does the solution looks like <img src="https://user-images.githubusercontent.com/35831811/187230574-3bef43ae-32ec-4077-91d3-6ae4b0804679.png" height="550px"> ### Todo <!-- In case some parts are still missing, list them here. - [ ] Changelog --> - Other things related to the whole web app look and feel eg. the login page... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 21:36:39 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#922
No description provided.