[PR #574] [MERGED] Update bacon/bacon-qr-code to also support v2 #902

New issue

Closed

opened 2026-02-25 21:36:35 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:36:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/574
Author: @xorti
Created: 6/28/2022
Status: ✅ Merged
Merged: 7/10/2022
Merged by: @marclaporte

Base: master ← Head: bacon-qr-code-update

📝 Commits (1)

393ee75 Update bacon/bacon-qr-code to also support v2

📊 Changes

3 files changed (+2 additions, -1369 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 composer.json (+1 -1)
➖ composer.lock (+0 -1368)

📄 Description

Also remove composer.lock

Pullrequest

The library endroid/qr-code had a dependency of bacon/bacon-qr-code between 1.0.0 and ^2.0.0 depending on the installed version of the endroid/qr-code library.

Cypht can still use any version of the bacon/bacon-qr-code since the class names are exactly the same.

Note: The composer.lock was not updated with the changes in composer.json, but also it should not be versioning, allowing composer to manage the packages depending on the software dependencies.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/574 **Author:** [@xorti](https://github.com/xorti) **Created:** 6/28/2022 **Status:** ✅ Merged **Merged:** 7/10/2022 **Merged by:** [@marclaporte](https://github.com/marclaporte) **Base:** `master` ← **Head:** `bacon-qr-code-update` --- ### 📝 Commits (1) - [`393ee75`](https://github.com/cypht-org/cypht/commit/393ee750198dc5270c4d3ba48cccc64c8189c231) Update bacon/bacon-qr-code to also support v2 ### 📊 Changes **3 files changed** (+2 additions, -1369 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `composer.json` (+1 -1) ➖ `composer.lock` (+0 -1368) </details> ### 📄 Description - Also remove composer.lock ## Pullrequest The library `endroid/qr-code` had a dependency of `bacon/bacon-qr-code` between `1.0.0` and `^2.0.0` depending on the installed version of the `endroid/qr-code` library. Cypht can still use any version of the `bacon/bacon-qr-code` since the class names are exactly the same. --- Note: The `composer.lock` was not updated with the changes in composer.json, but also it should not be versioning, allowing composer to manage the packages depending on the software dependencies. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>