[PR #559] [MERGED] Fix bug in PHP 8.1 when require lib/request.php due to $GLOBALS modif… #891

New issue

Closed

opened 2026-02-25 21:36:33 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:36:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/559
Author: @xorti
Created: 3/9/2022
Status: ✅ Merged
Merged: 3/9/2022
Merged by: @jasonmunro

Base: master ← Head: fix-globals-php81

📝 Commits (1)

3189f30 Fix bug in PHP 8.1 when require lib/request.php due to $GLOBALS modification changes

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 lib/request.php (+4 -1)

📄 Description

…ication changes

Pullrequest

This pull request fixes an issue in PHP 8.1 that was failing with Fatal Error when requiring the file lib/request.php due to $GLOBALS modification.

Fatal error: $GLOBALS can only be modified using the $GLOBALS[$name] = $value syntax in /var/www/html/vendor/jason-munro/cypht/lib/request.php on line 153

Issues

None

Checklist

None

How2Test

Run the following code with PHP8.1 to see the issue: php -r "require 'lib/request.php';"

Todo

None

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/559 **Author:** [@xorti](https://github.com/xorti) **Created:** 3/9/2022 **Status:** ✅ Merged **Merged:** 3/9/2022 **Merged by:** [@jasonmunro](https://github.com/jasonmunro) **Base:** `master` ← **Head:** `fix-globals-php81` --- ### 📝 Commits (1) - [`3189f30`](https://github.com/cypht-org/cypht/commit/3189f30077001ce1b9abcf4628e7aaa12931972d) Fix bug in PHP 8.1 when require lib/request.php due to $GLOBALS modification changes ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `lib/request.php` (+4 -1) </details> ### 📄 Description …ication changes ## Pullrequest This pull request fixes an issue in PHP 8.1 that was failing with **Fatal Error** when requiring the file `lib/request.php` due to `$GLOBALS` modification. ``` Fatal error: $GLOBALS can only be modified using the $GLOBALS[$name] = $value syntax in /var/www/html/vendor/jason-munro/cypht/lib/request.php on line 153 ``` ### Issues  - [X] None ### Checklist  - [X] None ### How2Test   - [X] Run the following code with PHP8.1 to see the issue: `php -r "require 'lib/request.php';"` ### Todo  - [X] None --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>