[PR #518] [MERGED] Fix draft attachment and remove legacy draft fallback #865

New issue

Closed

opened 2026-02-25 21:36:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:36:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/518
Author: @henrique-borba
Created: 9/14/2021
Status: ✅ Merged
Merged: 9/30/2021
Merged by: @jasonmunro

Base: master ← Head: draft-attachment-fix

📝 Commits (4)

3924f85 Fix draft attachment and remove legacy draft fallback
50b50d4 Attachments are downloaded when a previous saved draft is opened
a70d3d9 Fixed attachment delete and file parameters during the draft attachment download
c880912 Commented the code snippet that contains the redownload of attachments

📊 Changes

2 files changed (+65 additions, -26 deletions)

View changed files

📝 modules/smtp/modules.php (+55 -24)
📝 modules/smtp/site.js (+10 -2)

📄 Description

This PR removes the fallback of the legacy draft and fixes the ID issues that prevented the correct functioning of the IMAP drafts attachment.

SOLUTION

Fixed the way the attachment cache IDs are updated when the draft ID is changed while editing
When a previously saved draft with attachments is opened for editing, the attachments are downloaded to the attachments folder and added to the uploaded file cache. That way, when editing is complete, the new draft version will contain the files previously uploaded in the previous draft version.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/518 **Author:** [@henrique-borba](https://github.com/henrique-borba) **Created:** 9/14/2021 **Status:** ✅ Merged **Merged:** 9/30/2021 **Merged by:** [@jasonmunro](https://github.com/jasonmunro) **Base:** `master` ← **Head:** `draft-attachment-fix` --- ### 📝 Commits (4) - [`3924f85`](https://github.com/cypht-org/cypht/commit/3924f85f3aec1bccf10c313796107bc3e51c38e0) Fix draft attachment and remove legacy draft fallback - [`50b50d4`](https://github.com/cypht-org/cypht/commit/50b50d42b5a0b955eeef913714440c24a5dde016) Attachments are downloaded when a previous saved draft is opened - [`a70d3d9`](https://github.com/cypht-org/cypht/commit/a70d3d9d6b92b2c1783389eb03e7d2316f27156d) Fixed attachment delete and file parameters during the draft attachment download - [`c880912`](https://github.com/cypht-org/cypht/commit/c88091289729308b24fcbd8db376b6df2aa3aefa) Commented the code snippet that contains the redownload of attachments ### 📊 Changes **2 files changed** (+65 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `modules/smtp/modules.php` (+55 -24) 📝 `modules/smtp/site.js` (+10 -2) </details> ### 📄 Description This PR removes the fallback of the legacy draft and fixes the ID issues that prevented the correct functioning of the IMAP drafts attachment. **SOLUTION** - Fixed the way the attachment cache IDs are updated when the draft ID is changed while editing - When a previously saved draft with attachments is opened for editing, the attachments are downloaded to the attachments folder and added to the uploaded file cache. That way, when editing is complete, the new draft version will contain the files previously uploaded in the previous draft version. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>