[PR #507] [MERGED] Fixed combined inbox not updating messages after combined folder removal #858

New issue

Closed

opened 2026-02-25 21:36:27 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:36:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/507
Author: @henrique-borba
Created: 8/24/2021
Status: ✅ Merged
Merged: 9/14/2021
Merged by: @jasonmunro

Base: master ← Head: combined-inbox-cache-hotfix

📝 Commits (1)

519274b Fixed combined inbox not updating messages after combined folder removal

📊 Changes

1 file changed (+11 additions, -1 deletions)

View changed files

📝 modules/imap/site.js (+11 -1)

📄 Description

Fixed combined inbox not updating messages after combined folder removal

This PR fixes a problem where, after removing a mailbox from the combined mailbox, messages from it are not removed from the combined mailbox.

Steps to reproduce

Open the "Everything" combined mailbox
Remove one of your mailbox from the combined mailbox using the top right button
Open the "Everything" combined mailbox again
Messages from the removed mailbox are still shown

How the fix works

The clear_imap_page_combined_inbox function was created in the site.js of the IMAP module which allows clearing the combined mailbox cache in any other mailbox
When update_imap_combined_source is triggered, it calls clear_imap_page_combined_inbox to clear the combined mailbox cache

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/507 **Author:** [@henrique-borba](https://github.com/henrique-borba) **Created:** 8/24/2021 **Status:** ✅ Merged **Merged:** 9/14/2021 **Merged by:** [@jasonmunro](https://github.com/jasonmunro) **Base:** `master` ← **Head:** `combined-inbox-cache-hotfix` --- ### 📝 Commits (1) - [`519274b`](https://github.com/cypht-org/cypht/commit/519274b44df3584dee9cc4889cab0ab0ae7940e4) Fixed combined inbox not updating messages after combined folder removal ### 📊 Changes **1 file changed** (+11 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `modules/imap/site.js` (+11 -1) </details> ### 📄 Description ## Fixed combined inbox not updating messages after combined folder removal This PR fixes a problem where, after removing a mailbox from the combined mailbox, messages from it are not removed from the combined mailbox. ## Steps to reproduce - Open the "Everything" combined mailbox - Remove one of your mailbox from the combined mailbox using the top right button - Open the "Everything" combined mailbox again - Messages from the removed mailbox are still shown ## How the fix works - The clear_imap_page_combined_inbox function was created in the site.js of the IMAP module which allows clearing the combined mailbox cache in any other mailbox - When update_imap_combined_source is triggered, it calls clear_imap_page_combined_inbox to clear the combined mailbox cache --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>