[PR #503] [MERGED] some clean up after PR 501 #854

Closed
opened 2026-02-25 21:36:26 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/503
Author: @Revisto
Created: 7/20/2021
Status: Merged
Merged: 7/20/2021
Merged by: @jasonmunro

Base: masterHead: farsi


📝 Commits (2)

  • aab263c add hm_language_direction function
  • 9652c65 use JQuery, move added page load section to an existing one and use cleaner ways to get url and interface direction

📊 Changes

2 files changed (+10 additions, -15 deletions)

View changed files

📝 modules/core/output_modules.php (+1 -0)
📝 modules/core/site.js (+9 -15)

📄 Description

Pull request

Hello, this is Revisto from the WikiSuite project.
I did some clean-up around the javascript based on the things that Jason mentioned on Gitter. I shorted syntaxes using JQuery and used built-in functions for getting URLs and added a function for getting the interface direction. I also moved the page load section I added myself to an existing one.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/503 **Author:** [@Revisto](https://github.com/Revisto) **Created:** 7/20/2021 **Status:** ✅ Merged **Merged:** 7/20/2021 **Merged by:** [@jasonmunro](https://github.com/jasonmunro) **Base:** `master` ← **Head:** `farsi` --- ### 📝 Commits (2) - [`aab263c`](https://github.com/cypht-org/cypht/commit/aab263c239cc8552a11fa5400b005073882e40f8) add hm_language_direction function - [`9652c65`](https://github.com/cypht-org/cypht/commit/9652c6556df1d4728afb61731ea406398867930a) use JQuery, move added page load section to an existing one and use cleaner ways to get url and interface direction ### 📊 Changes **2 files changed** (+10 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `modules/core/output_modules.php` (+1 -0) 📝 `modules/core/site.js` (+9 -15) </details> ### 📄 Description ## Pull request Hello, this is Revisto from the WikiSuite project. I did some clean-up around the javascript based on the things that Jason mentioned on Gitter. I shorted syntaxes using JQuery and used built-in functions for getting URLs and added a function for getting the interface direction. I also moved the page load section I added myself to an existing one. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 21:36:26 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#854
No description provided.