[PR #464] [MERGED] Hotfix for the default email in the SMTP list when using the mailing and base IMAP draft implementation #830

New issue

Closed

opened 2026-02-25 21:36:22 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:36:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/464
Author: @henrique-borba
Created: 4/9/2021
Status: ✅ Merged
Merged: 5/5/2021
Merged by: @jasonmunro

Base: master ← Head: master

📝 Commits (10+)

a05df77 Merge pull request #2 from jasonmunro/master
83d0400 Hotfix for the default email in the SMTP list when using the mailing list options
6b55ae0 Removed excess breaks for better code readability
81bf9fd draft_smtp must be filtered as string and not float
b74ca25 Implemented the draft settings back to imap_folders
e2cce19 Base implementation for IMAP drafts
cee45de Fixed error messsage text in save_imap_draft when append_end return false
34f6d01 Merge pull request #3 from jasonmunro/master
34e4fe1 Draft compose and labels
c5ef783 Draft editing implementation

📊 Changes

8 files changed (+205 additions, -16 deletions)

View changed files

📝 modules/core/message_list_functions.php (+4 -0)
📝 modules/imap/functions.php (+6 -1)
📝 modules/imap/hm-imap.php (+4 -2)
📝 modules/imap_folders/setup.php (+1 -1)
📝 modules/smtp/hm-mime-message.php (+5 -1)
📝 modules/smtp/modules.php (+174 -6)
📝 modules/smtp/setup.php (+4 -1)
📝 modules/smtp/site.js (+7 -4)

📄 Description

Pullrequest

Hotfix for https://github.com/jasonmunro/cypht/pull/463

In the previous pull request, the SMTP profile user must have a domain to be found and selected. With this update, the SMTP module will try other ways of comparison to identify which SMTP profile to use.

I used a more direct way and put the responsibility of searching for the profile in the SMTP module itself instead of the IMAP module as discussed on Gitter.

IMAP Draft Support

When Draft Folders are configured for a specific IMAP account, the save button will use imap append to save the draft in the specific folder. Check todo list for upcoming necessary updates.

Issues

Checklist

None

How2Test

Configure a Draft folder for a specific draft account
Compose a new message
Save your composed message
Check if message shows in the configured Draft folder

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/464 **Author:** [@henrique-borba](https://github.com/henrique-borba) **Created:** 4/9/2021 **Status:** ✅ Merged **Merged:** 5/5/2021 **Merged by:** [@jasonmunro](https://github.com/jasonmunro) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`a05df77`](https://github.com/cypht-org/cypht/commit/a05df7773c8f2a3b7abef516656866637fa69fa2) Merge pull request #2 from jasonmunro/master - [`83d0400`](https://github.com/cypht-org/cypht/commit/83d040002c1ffca8efaa72737b492fc911f54573) Hotfix for the default email in the SMTP list when using the mailing list options - [`6b55ae0`](https://github.com/cypht-org/cypht/commit/6b55ae0fe4193a5b48f2c202fe6d6e5c6f744761) Removed excess breaks for better code readability - [`81bf9fd`](https://github.com/cypht-org/cypht/commit/81bf9fd1157bd6637a89c6de14a6e0232f1caf32) draft_smtp must be filtered as string and not float - [`b74ca25`](https://github.com/cypht-org/cypht/commit/b74ca2506d6ff49396a5de53efce60cfcbad723d) Implemented the draft settings back to imap_folders - [`e2cce19`](https://github.com/cypht-org/cypht/commit/e2cce196cc9473e05a24f0ecb49f9fa44b833c03) Base implementation for IMAP drafts - [`cee45de`](https://github.com/cypht-org/cypht/commit/cee45de7e570a907f7a12da222595d55ea1154a6) Fixed error messsage text in save_imap_draft when append_end return false - [`34f6d01`](https://github.com/cypht-org/cypht/commit/34f6d01b549a59ce789dc4b19912af5d999339e1) Merge pull request #3 from jasonmunro/master - [`34e4fe1`](https://github.com/cypht-org/cypht/commit/34e4fe1106365f06d19740c957b7efa21dd91c06) Draft compose and labels - [`c5ef783`](https://github.com/cypht-org/cypht/commit/c5ef783af7caeede1133638e914a2cdaaabc2beb) Draft editing implementation ### 📊 Changes **8 files changed** (+205 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `modules/core/message_list_functions.php` (+4 -0) 📝 `modules/imap/functions.php` (+6 -1) 📝 `modules/imap/hm-imap.php` (+4 -2) 📝 `modules/imap_folders/setup.php` (+1 -1) 📝 `modules/smtp/hm-mime-message.php` (+5 -1) 📝 `modules/smtp/modules.php` (+174 -6) 📝 `modules/smtp/setup.php` (+4 -1) 📝 `modules/smtp/site.js` (+7 -4) </details> ### 📄 Description ## Pullrequest **Hotfix for** https://github.com/jasonmunro/cypht/pull/463 In the previous pull request, the SMTP profile user must have a domain to be found and selected. With this update, the SMTP module will try other ways of comparison to identify which SMTP profile to use. I used a more direct way and put the responsibility of searching for the profile in the SMTP module itself instead of the IMAP module as discussed on Gitter. **IMAP Draft Support** When Draft Folders are configured for a specific IMAP account, the save button will use imap append to save the draft in the specific folder. Check todo list for upcoming necessary updates. ### Issues - [X] https://github.com/jasonmunro/cypht/issues/257 - [X] https://github.com/jasonmunro/cypht/issues/465 ### Checklist  - [X] None ### How2Test - [x] Configure a Draft folder for a specific draft account - [x] Compose a new message - [x] Save your composed message - [x] Check if message shows in the configured Draft folder --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>