[PR #461] [MERGED] fix copy/move folder list when checking a message from the list before all sources have loaded #825

New issue

Closed

opened 2026-02-25 21:36:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:36:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/461
Author: @kroky
Created: 3/25/2021
Status: ✅ Merged
Merged: 4/1/2021
Merged by: @jasonmunro

Base: master ← Head: bugfix/checkbox-move

📝 Commits (1)

f829bc0 fix copy/move folder list when checking a message from the list before all sources have loaded

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 modules/imap/site.js (+2 -2)

📄 Description

Case: you have multiple imap sources. Nothing is cached in local browser's session cache. Click Everything (combined inbox). Check a message while sources are loaded (one or two have loaded but the rest have not).
Result: Copy/Move buttons are disabled and no folders appear inside.
This PR fixes the issue by attaching the event handles to the body.

However, there is a deeper issue I was not able to resolve. When a checkbox is checked while other sources are loading, Hm_Ajax.abort flag is set and the rest of the sources never complete loading - their results don't appear in the combined inbox. Even if you reload via the refresh button at the top, the results don't appear until you deselect all checkboxes. Is there a reason why further ajax calls are aborted if a checkbox is checked? I think we should still process their results as they were queued and it doesn't matter if user clicks something quickly or not. @jasonmunro let me know your thoughts here.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/461 **Author:** [@kroky](https://github.com/kroky) **Created:** 3/25/2021 **Status:** ✅ Merged **Merged:** 4/1/2021 **Merged by:** [@jasonmunro](https://github.com/jasonmunro) **Base:** `master` ← **Head:** `bugfix/checkbox-move` --- ### 📝 Commits (1) - [`f829bc0`](https://github.com/cypht-org/cypht/commit/f829bc0119fa33ba23b797cc3c4d30fc2aabab6a) fix copy/move folder list when checking a message from the list before all sources have loaded ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `modules/imap/site.js` (+2 -2) </details> ### 📄 Description Case: you have multiple imap sources. Nothing is cached in local browser's session cache. Click Everything (combined inbox). Check a message while sources are loaded (one or two have loaded but the rest have not). Result: Copy/Move buttons are disabled and no folders appear inside. This PR fixes the issue by attaching the event handles to the body. However, there is a deeper issue I was not able to resolve. When a checkbox is checked while other sources are loading, Hm_Ajax.abort flag is set and the rest of the sources never complete loading - their results don't appear in the combined inbox. Even if you reload via the refresh button at the top, the results don't appear until you deselect all checkboxes. Is there a reason why further ajax calls are aborted if a checkbox is checked? I think we should still process their results as they were queued and it doesn't matter if user clicks something quickly or not. @jasonmunro let me know your thoughts here. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>