[PR #454] [MERGED] use uniqid instead of php array indexing for server list #821

New issue

Closed

opened 2026-02-25 21:36:20 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:36:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/454
Author: @kroky
Created: 2/23/2021
Status: ✅ Merged
Merged: 2/25/2021
Merged by: @jasonmunro

Base: master ← Head: feature/server-list-by-uniqid

📝 Commits (1)

4765e8e use uniqid instead of php array indexing for server list (imap, jmap, smtp, pop3, feeds) but keep backward compatibility - should help keeping special folder assignments when deleting imap servers

📊 Changes

17 files changed (+52 additions, -53 deletions)

View changed files

📝 lib/servers.php (+5 -5)
📝 modules/core/setup.php (+1 -1)
📝 modules/feeds/modules.php (+4 -4)
📝 modules/feeds/setup.php (+1 -1)
📝 modules/github/modules.php (+1 -1)
📝 modules/github/setup.php (+1 -1)
📝 modules/gmail_contacts/modules.php (+1 -1)
📝 modules/imap/functions.php (+5 -6)
📝 modules/imap/handler_modules.php (+10 -10)
📝 modules/imap/output_modules.php (+2 -2)
📝 modules/imap/setup.php (+4 -4)
📝 modules/imap/site.js (+1 -1)
📝 modules/pop3/modules.php (+7 -7)
📝 modules/pop3/setup.php (+3 -3)
📝 modules/smtp/modules.php (+4 -4)
📝 modules/smtp/setup.php (+1 -1)
📝 tests/phpunit/servers.php (+1 -1)

📄 Description

(imap, jma, smtp, pop3, feeds) but keep backward compatibility - should help keeping special folder assignments when deleting imap servers.

https://github.com/jasonmunro/cypht/issues/349

Newly added servers use uniq ID, so deleting or reordering server list won't negatively affect other servers or special folder assignments. Existing settings are kept as integer IDs.

Fixed an issue with tests but please double check!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/454 **Author:** [@kroky](https://github.com/kroky) **Created:** 2/23/2021 **Status:** ✅ Merged **Merged:** 2/25/2021 **Merged by:** [@jasonmunro](https://github.com/jasonmunro) **Base:** `master` ← **Head:** `feature/server-list-by-uniqid` --- ### 📝 Commits (1) - [`4765e8e`](https://github.com/cypht-org/cypht/commit/4765e8efd7210425970416c995c529cd50cec2e1) use uniqid instead of php array indexing for server list (imap, jmap, smtp, pop3, feeds) but keep backward compatibility - should help keeping special folder assignments when deleting imap servers ### 📊 Changes **17 files changed** (+52 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `lib/servers.php` (+5 -5) 📝 `modules/core/setup.php` (+1 -1) 📝 `modules/feeds/modules.php` (+4 -4) 📝 `modules/feeds/setup.php` (+1 -1) 📝 `modules/github/modules.php` (+1 -1) 📝 `modules/github/setup.php` (+1 -1) 📝 `modules/gmail_contacts/modules.php` (+1 -1) 📝 `modules/imap/functions.php` (+5 -6) 📝 `modules/imap/handler_modules.php` (+10 -10) 📝 `modules/imap/output_modules.php` (+2 -2) 📝 `modules/imap/setup.php` (+4 -4) 📝 `modules/imap/site.js` (+1 -1) 📝 `modules/pop3/modules.php` (+7 -7) 📝 `modules/pop3/setup.php` (+3 -3) 📝 `modules/smtp/modules.php` (+4 -4) 📝 `modules/smtp/setup.php` (+1 -1) 📝 `tests/phpunit/servers.php` (+1 -1) </details> ### 📄 Description (imap, jma, smtp, pop3, feeds) but keep backward compatibility - should help keeping special folder assignments when deleting imap servers. https://github.com/jasonmunro/cypht/issues/349 Newly added servers use uniq ID, so deleting or reordering server list won't negatively affect other servers or special folder assignments. Existing settings are kept as integer IDs. Fixed an issue with tests but please double check! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>