[PR #346] [MERGED] fix compose page handler module precedence #788

New issue

Closed

opened 2026-02-25 21:36:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:36:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/346
Author: @kroky
Created: 5/21/2019
Status: ✅ Merged
Merged: 5/21/2019
Merged by: @jasonmunro

Base: master ← Head: bugfix/profile-load-precedence

📝 Commits (1)

35d33dd fix compose page handler module precedence - profiles that depend on smtp servers list happened to load before the smtp servers being loaded from config

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 modules/profiles/setup.php (+1 -1)

📄 Description

This is a minor fix for the following bug:

profiles page had the smtp module load_smtp_servers_from_config function executed before profile_data which correctly loaded the smtp server list from config
compose page was executing load_smtp_servers_from_config after compose_profile_data and thus defined servers in config did not correctly auto-created the default profile when we had exactly one smtp and imap server

Both pages defined the relevant modules to be executed after load_user_data, however alphabetic sort of the names or something else prevented compose page to get the right order.
I merely changed compose_profile_data load requirement to be after load_smtp_servers_from_config as it depends on it to function correctly.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/346 **Author:** [@kroky](https://github.com/kroky) **Created:** 5/21/2019 **Status:** ✅ Merged **Merged:** 5/21/2019 **Merged by:** [@jasonmunro](https://github.com/jasonmunro) **Base:** `master` ← **Head:** `bugfix/profile-load-precedence` --- ### 📝 Commits (1) - [`35d33dd`](https://github.com/cypht-org/cypht/commit/35d33dd70dc8d77e7ef6d4416c844d3691049381) fix compose page handler module precedence - profiles that depend on smtp servers list happened to load before the smtp servers being loaded from config ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `modules/profiles/setup.php` (+1 -1) </details> ### 📄 Description This is a minor fix for the following bug: - profiles page had the smtp module load_smtp_servers_from_config function executed before profile_data which correctly loaded the smtp server list from config - compose page was executing load_smtp_servers_from_config after compose_profile_data and thus defined servers in config did not correctly auto-created the default profile when we had exactly one smtp and imap server Both pages defined the relevant modules to be executed after load_user_data, however alphabetic sort of the names or something else prevented compose page to get the right order. I merely changed compose_profile_data load requirement to be after load_smtp_servers_from_config as it depends on it to function correctly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>