[PR #335] [MERGED] add cookie_path configuration parameter #787

Closed
opened 2026-02-25 21:36:14 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/335
Author: @kroky
Created: 4/2/2019
Status: Merged
Merged: 4/3/2019
Merged by: @jasonmunro

Base: masterHead: feature/cookie-path


📝 Commits (2)

  • aa835fa add cookie_path configuration parameter
  • e64797a add example for cookie path setting

📊 Changes

2 files changed (+31 additions, -2 deletions)

View changed files

📝 hm3.sample.ini (+14 -1)
📝 lib/session_base.php (+17 -1)

📄 Description

Pullrequest

Add ability to specify the cookie path the same way cookie domain can be specified through configuration. It is useful in scenarios where mod_rewrite is used and current Cypht cookie path retrieval mechanism incorrectly puts the cookie inside a directory which is actually a webpage, hence the inability to access those cookies later. E.g. request URI like /tiki-git/Webmail?page=compose will end up with cookie path /tiki-git/Webmail/ which is incorrect as the path is /tiki-git/ only.

Issues

  • None

Checklist

  • Config Update

How2Test

Specify a specific cookie path and check cookies are still set - e.g. compose message returns back the proper Message Sent response.

Todo

  • Changelog

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/335 **Author:** [@kroky](https://github.com/kroky) **Created:** 4/2/2019 **Status:** ✅ Merged **Merged:** 4/3/2019 **Merged by:** [@jasonmunro](https://github.com/jasonmunro) **Base:** `master` ← **Head:** `feature/cookie-path` --- ### 📝 Commits (2) - [`aa835fa`](https://github.com/cypht-org/cypht/commit/aa835fa896828200965ad5befe26ee24b49c1304) add cookie_path configuration parameter - [`e64797a`](https://github.com/cypht-org/cypht/commit/e64797a5204c2c3f1e9cf79a1f6c09c8b7b4c34d) add example for cookie path setting ### 📊 Changes **2 files changed** (+31 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `hm3.sample.ini` (+14 -1) 📝 `lib/session_base.php` (+17 -1) </details> ### 📄 Description ## Pullrequest Add ability to specify the cookie path the same way cookie domain can be specified through configuration. It is useful in scenarios where mod_rewrite is used and current Cypht cookie path retrieval mechanism incorrectly puts the cookie inside a directory which is actually a webpage, hence the inability to access those cookies later. E.g. request URI like /tiki-git/Webmail?page=compose will end up with cookie path /tiki-git/Webmail/ which is incorrect as the path is /tiki-git/ only. ### Issues - [X] None ### Checklist - [ ] Config Update ### How2Test Specify a specific cookie path and check cookies are still set - e.g. compose message returns back the proper Message Sent response. ### Todo - [ ] Changelog --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 21:36:14 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#787
No description provided.