mirror of
https://github.com/cypht-org/cypht.git
synced 2026-04-25 13:05:53 +03:00
[PR #335] [MERGED] add cookie_path configuration parameter #787
Labels
No labels
2fa
I18N
PGP
Security
Security
account
advanced_search
advanced_search
announcement
api_login
authentication
awaiting feedback
blocker
bug
bug
bug
calendar
config
contacts
core
core
devops
docker
docs
duplicate
dynamic_login
enhancement
epic
feature
feeds
framework
github
github
gmail_contacts
good first issue
help wanted
history
history
imap
imap_folders
inline_message
installation
keyboard_shortcuts
keyboard_shortcuts
ldap_contacts
mobile
need-ssh-access
new module set
nux
pop3
profiles
pull-request
question
refactor
release
research
saved_searches
smtp
strategic
tags
tests
themes
website
wordpress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/cypht#787
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/cypht-org/cypht/pull/335
Author: @kroky
Created: 4/2/2019
Status: ✅ Merged
Merged: 4/3/2019
Merged by: @jasonmunro
Base:
master← Head:feature/cookie-path📝 Commits (2)
aa835faadd cookie_path configuration parametere64797aadd example for cookie path setting📊 Changes
2 files changed (+31 additions, -2 deletions)
View changed files
📝
hm3.sample.ini(+14 -1)📝
lib/session_base.php(+17 -1)📄 Description
Pullrequest
Add ability to specify the cookie path the same way cookie domain can be specified through configuration. It is useful in scenarios where mod_rewrite is used and current Cypht cookie path retrieval mechanism incorrectly puts the cookie inside a directory which is actually a webpage, hence the inability to access those cookies later. E.g. request URI like /tiki-git/Webmail?page=compose will end up with cookie path /tiki-git/Webmail/ which is incorrect as the path is /tiki-git/ only.
Issues
Checklist
How2Test
Specify a specific cookie path and check cookies are still set - e.g. compose message returns back the proper Message Sent response.
Todo
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.