mirror of
https://github.com/cypht-org/cypht.git
synced 2026-04-25 04:56:03 +03:00
[PR #342] [MERGED] allow usage of custom class for implemeting user configuration persistence #786
Labels
No labels
2fa
I18N
PGP
Security
Security
account
advanced_search
advanced_search
announcement
api_login
authentication
awaiting feedback
blocker
bug
bug
bug
calendar
config
contacts
core
core
devops
docker
docs
duplicate
dynamic_login
enhancement
epic
feature
feeds
framework
github
github
gmail_contacts
good first issue
help wanted
history
history
imap
imap_folders
inline_message
installation
keyboard_shortcuts
keyboard_shortcuts
ldap_contacts
mobile
need-ssh-access
new module set
nux
pop3
profiles
pull-request
question
refactor
release
research
saved_searches
smtp
strategic
tags
tests
themes
website
wordpress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/cypht#786
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/cypht-org/cypht/pull/342
Author: @kroky
Created: 4/29/2019
Status: ✅ Merged
Merged: 4/30/2019
Merged by: @jasonmunro
Base:
master← Head:feature/custom-user-config📝 Commits (1)
ecb4381allow usage of custom class for implemeting user configuration persistence📊 Changes
3 files changed (+21 additions, -5 deletions)
View changed files
📝
hm3.sample.ini(+8 -5)📝
lib/config.php(+11 -0)📝
tests/phpunit/config.php(+2 -0)📄 Description
We needed a way to store user configuration inside Tiki database as user preferences as we already control authentication using Tiki. Saving to a separate table using DB method did not accomplish what we needed as we didn't go through the normal authentication login form (to trigger initial configuration load) and we also didn't use save settings page. Basically, I needed a way to override
load_user_config_objectfunction but there was no easy way to do it. I added another configuration option for custom implementation of the user configuration persistence class. Also extended the unit test for that function. Hope all this makes sense!🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.