mirror of
https://github.com/cypht-org/cypht.git
synced 2026-04-25 04:56:03 +03:00
[PR #326] [MERGED] allow easier integration into 3rd party systems #784
Labels
No labels
2fa
I18N
PGP
Security
Security
account
advanced_search
advanced_search
announcement
api_login
authentication
awaiting feedback
blocker
bug
bug
bug
calendar
config
contacts
core
core
devops
docker
docs
duplicate
dynamic_login
enhancement
epic
feature
feeds
framework
github
github
gmail_contacts
good first issue
help wanted
history
history
imap
imap_folders
inline_message
installation
keyboard_shortcuts
keyboard_shortcuts
ldap_contacts
mobile
need-ssh-access
new module set
nux
pop3
profiles
pull-request
question
refactor
release
research
saved_searches
smtp
strategic
tags
tests
themes
website
wordpress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/cypht#784
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/cypht-org/cypht/pull/326
Author: @kroky
Created: 3/13/2019
Status: ✅ Merged
Merged: 3/14/2019
Merged by: @jasonmunro
Base:
master← Head:feature/easier-integration📝 Commits (1)
807797callow easier integration into 3rd party systems - specify session class and ability to return output from dispatcher📊 Changes
2 files changed (+7 additions, -4 deletions)
View changed files
📝
lib/dispatch.php(+4 -2)📝
lib/session_base.php(+3 -2)📄 Description
Hi Jason,
Thanks for the great work on Cypht! We are integrating Cypht into Tiki with Marc Laporte. I have found some missing pieces in the core, so we can embed Cypht into Tiki or reuse Tiki classes for session handling, authentication and similar tasks.
In essence, this PR solves 2 issues:
I have done the rest of the modifications through config tweaks (mainly turning off specific modules/functions), as to keep the needed changes to Cypht core at the minimum. I think Marc Laporte can show you a demo of the resulting product if you are interested.
If you see any problems with the code or improvements are necessary, I will be glad to discuss!
Regards,
Victor
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.