[PR #326] [MERGED] allow easier integration into 3rd party systems #784

Closed
opened 2026-02-25 21:36:13 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/326
Author: @kroky
Created: 3/13/2019
Status: Merged
Merged: 3/14/2019
Merged by: @jasonmunro

Base: masterHead: feature/easier-integration


📝 Commits (1)

  • 807797c allow easier integration into 3rd party systems - specify session class and ability to return output from dispatcher

📊 Changes

2 files changed (+7 additions, -4 deletions)

View changed files

📝 lib/dispatch.php (+4 -2)
📝 lib/session_base.php (+3 -2)

📄 Description

Hi Jason,

Thanks for the great work on Cypht! We are integrating Cypht into Tiki with Marc Laporte. I have found some missing pieces in the core, so we can embed Cypht into Tiki or reuse Tiki classes for session handling, authentication and similar tasks.

In essence, this PR solves 2 issues:

  • inability to override session class. Yes, we have site module lib but it is located in Cypht modules dir which we plan to install via composer and do not want to change anything once installed - i.e. don't want to override Custom_Session class there with our own but specify another session class from another location. This is solved via injected config variable containing the session class name.
  • inability to return the output of the dispatcher and decide what to do with it on a later stage of the script execution. We need this in order to embed Cypht into Tiki pages as a wiki plugin where we cannot simply echo the contents of Cypht output modules but need to hold on until the whole page is constructed.

I have done the rest of the modifications through config tweaks (mainly turning off specific modules/functions), as to keep the needed changes to Cypht core at the minimum. I think Marc Laporte can show you a demo of the resulting product if you are interested.

If you see any problems with the code or improvements are necessary, I will be glad to discuss!

Regards,
Victor


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/326 **Author:** [@kroky](https://github.com/kroky) **Created:** 3/13/2019 **Status:** ✅ Merged **Merged:** 3/14/2019 **Merged by:** [@jasonmunro](https://github.com/jasonmunro) **Base:** `master` ← **Head:** `feature/easier-integration` --- ### 📝 Commits (1) - [`807797c`](https://github.com/cypht-org/cypht/commit/807797cb859f262dc065a4f18e401225e55fc042) allow easier integration into 3rd party systems - specify session class and ability to return output from dispatcher ### 📊 Changes **2 files changed** (+7 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `lib/dispatch.php` (+4 -2) 📝 `lib/session_base.php` (+3 -2) </details> ### 📄 Description Hi Jason, Thanks for the great work on Cypht! We are integrating Cypht into [Tiki](https://tiki.org/) with Marc Laporte. I have found some missing pieces in the core, so we can embed Cypht into Tiki or reuse Tiki classes for session handling, authentication and similar tasks. In essence, this PR solves 2 issues: - inability to override session class. Yes, we have site module lib but it is located in Cypht modules dir which we plan to install via composer and do not want to change anything once installed - i.e. don't want to override Custom_Session class there with our own but specify another session class from another location. This is solved via injected config variable containing the session class name. - inability to return the output of the dispatcher and decide what to do with it on a later stage of the script execution. We need this in order to embed Cypht into Tiki pages as a wiki plugin where we cannot simply echo the contents of Cypht output modules but need to hold on until the whole page is constructed. I have done the rest of the modifications through config tweaks (mainly turning off specific modules/functions), as to keep the needed changes to Cypht core at the minimum. I think Marc Laporte can show you a demo of the resulting product if you are interested. If you see any problems with the code or improvements are necessary, I will be glad to discuss! Regards, Victor --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 21:36:13 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#784
No description provided.