[PR #321] [MERGED] Fix problems adding imap, smtp and probably more #783

New issue

Closed

opened 2026-02-25 21:36:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 21:36:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/321
Author: @Razvan0925
Created: 2/22/2019
Status: ✅ Merged
Merged: 2/22/2019
Merged by: @jasonmunro

Base: master ← Head: patch-1

📝 Commits (1)

b22a22b Fix problems adding imap, smtp and probably more

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 modules/core/site.js (+1 -1)

📄 Description

Pullrequest

When saving a new imap/smtp the email address is encoded ( @ is converted in %40 ) and because of this the authentication fails and it cannot be saved. This is an elegant solutions, otherwise every $form['field'] in every module should be urldecode() -ed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/321 **Author:** [@Razvan0925](https://github.com/Razvan0925) **Created:** 2/22/2019 **Status:** ✅ Merged **Merged:** 2/22/2019 **Merged by:** [@jasonmunro](https://github.com/jasonmunro) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`b22a22b`](https://github.com/cypht-org/cypht/commit/b22a22b969f7424af164ff1c496e93174f0d2871) Fix problems adding imap, smtp and probably more ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `modules/core/site.js` (+1 -1) </details> ### 📄 Description ## Pullrequest When saving a new imap/smtp the email address is encoded ( @ is converted in %40 ) and because of this the authentication fails and it cannot be saved. This is an elegant solutions, otherwise every $form['field'] in every module should be urldecode() -ed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>