[PR #172] [MERGED] Remove all click listeners before adding #770

Closed
opened 2026-02-25 21:36:11 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/cypht-org/cypht/pull/172
Author: @sjhernes
Created: 3/12/2017
Status: Merged
Merged: 3/13/2017
Merged by: @jasonmunro

Base: masterHead: patch-1


📝 Commits (1)

  • 9403ae6 Remove all click listeners before adding

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 modules/inline_message/site.js (+1 -0)

📄 Description

Not sure if this would be the best solution, but every time a click-event loads it adds another listener making a simple scroll through N mails gives N² requests on the server. Removing all listeners on click before adding solves this problem.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/cypht-org/cypht/pull/172 **Author:** [@sjhernes](https://github.com/sjhernes) **Created:** 3/12/2017 **Status:** ✅ Merged **Merged:** 3/13/2017 **Merged by:** [@jasonmunro](https://github.com/jasonmunro) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`9403ae6`](https://github.com/cypht-org/cypht/commit/9403ae663088c9a5c55d4731a4a09ba93e7601fd) Remove all click listeners before adding ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `modules/inline_message/site.js` (+1 -0) </details> ### 📄 Description Not sure if this would be the best solution, but every time a click-event loads it adds another listener making a simple scroll through N mails gives N² requests on the server. Removing all listeners on click before adding solves this problem. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 21:36:11 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#770
No description provided.