[GH-ISSUE #1540] 🐛 [Bug] No Pagination in Folders #678

Closed
opened 2026-02-25 21:35:39 +03:00 by kerem · 12 comments
Owner

Originally created by @ulfgebhardt on GitHub (Jun 7, 2025).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/1540

🐛 Bug

Select Folder, shows Page 1 in header

Image

Misses a Pagination Control at the bottom.

I did not find any way navigate to page 2.

This is an IMAP account

Version & Environment

Rev: [v2.4.2]

OS: []

Originally created by @ulfgebhardt on GitHub (Jun 7, 2025). Original GitHub issue: https://github.com/cypht-org/cypht/issues/1540 <!-- You can find the latest issue templates here https://github.com/ulfgebhardt/issue-templates --> ## 🐛 Bug <!-- Describe your issue in detail. Include screenshots if needed. Give us as much information as possible. Use a clear and concise description of what the bug is.--> Select Folder, shows `Page 1 in header` ![Image](https://github.com/user-attachments/assets/0584489c-5f1c-4719-93d8-c92bb9072bc8) Misses a Pagination Control at the bottom. I did not find any way navigate to page 2. This is an IMAP account ### Version & Environment <!-- Paste Git-Commit ID or Tag-Name here --> Rev: [v2.4.2] <!-- Specify your OS and OS Version here if the issue is (most likely) platform dependent. --> OS: []
kerem 2026-02-25 21:35:39 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@marclaporte commented on GitHub (Jun 8, 2025):

@ulfgebhardt Can you please test master?

We are stabilizing master, from which we will cut Cypht 2.5.0

<!-- gh-comment-id:2953350546 --> @marclaporte commented on GitHub (Jun 8, 2025): @ulfgebhardt Can you please test master? We are stabilizing master, from which we will cut Cypht 2.5.0
Author
Owner

@kroky commented on GitHub (Jun 9, 2025):

Note that master removed pagination in combined pages which used to be the way it worked in Cypht 1.x. Having paging in combined pages make it rather slow and hard to execute sorting correctly. If combined pages list sources for a specific period of time, it means they contain limited amount of items, by definition. If we still face issues with longer combined pages, we can introduce client-side pagination but server-side, we still need to get all emails in the chosen period of time for all sources in order to sort them correctly.

<!-- gh-comment-id:2955179219 --> @kroky commented on GitHub (Jun 9, 2025): Note that master removed pagination in combined pages which used to be the way it worked in Cypht 1.x. Having paging in combined pages make it rather slow and hard to execute sorting correctly. If combined pages list sources for a specific period of time, it means they contain limited amount of items, by definition. If we still face issues with longer combined pages, we can introduce client-side pagination but server-side, we still need to get all emails in the chosen period of time for all sources in order to sort them correctly.
Author
Owner

@ulfgebhardt commented on GitHub (Jun 13, 2025):

@marclaporte I use the project in production and I shy away from using the current master, since if needed its not guaranteed to be able to roll back.

@kroky I have this behaviour in an impa folder, not a combined folder

<!-- gh-comment-id:2971560567 --> @ulfgebhardt commented on GitHub (Jun 13, 2025): @marclaporte I use the project in production and I shy away from using the current master, since if needed its not guaranteed to be able to roll back. @kroky I have this behaviour in an impa folder, not a combined folder
Author
Owner

@marclaporte commented on GitHub (Jun 13, 2025):

since if needed its not guaranteed to be able to roll back

Right. But can't you run both in parallel? (I do)

<!-- gh-comment-id:2971909677 --> @marclaporte commented on GitHub (Jun 13, 2025): > since if needed its not guaranteed to be able to roll back Right. But can't you run both in parallel? (I do)
Author
Owner

@marclaporte commented on GitHub (Aug 20, 2025):

@ulfgebhardt We have a test site for which we could give you access. On this site, you could test Cypht master with our bogus data.

If you detect and report bugs on this test site, it is super easy for our dev team to address because they have full access to all the code and the server.

What do you think?

<!-- gh-comment-id:3206160902 --> @marclaporte commented on GitHub (Aug 20, 2025): @ulfgebhardt We have a test site for which we could give you access. On this site, you could test Cypht master with our bogus data. If you detect and report bugs on this test site, it is super easy for our dev team to address because they have full access to all the code and the server. What do you think?
Author
Owner

@ulfgebhardt commented on GitHub (Aug 21, 2025):

I can try to reproduce problems on your test environment if you like.

I can certainly say that there is many problems on my end your developers cannot reproduce and I wonder why this is.
An example is this issue or https://github.com/cypht-org/cypht/issues/1368 which I still experience.

I am running v2.4.2 - maybe an easy solution could be to release more often? I can certainly update to stable versions regularly.

<!-- gh-comment-id:3209317360 --> @ulfgebhardt commented on GitHub (Aug 21, 2025): I can try to reproduce problems on your test environment if you like. I can certainly say that there is many problems on my end your developers cannot reproduce and I wonder why this is. An example is this issue or https://github.com/cypht-org/cypht/issues/1368 which I still experience. I am running v2.4.2 - maybe an easy solution could be to release more often? I can certainly update to stable versions regularly.
Author
Owner

@marclaporte commented on GitHub (Aug 21, 2025):

maybe an easy solution could be to release more often?

Yes, that is what we must do, but it's not always easy :-)
https://github.com/cypht-org/cypht/issues/1624

<!-- gh-comment-id:3210563970 --> @marclaporte commented on GitHub (Aug 21, 2025): > maybe an easy solution could be to release more often? Yes, that is what we must do, but it's not always easy :-) https://github.com/cypht-org/cypht/issues/1624
Author
Owner

@marclaporte commented on GitHub (Aug 21, 2025):

I can try to reproduce problems on your test environment if you like.

Super! I will email you later today with credentials and put you in touch with main active devs.

<!-- gh-comment-id:3210569033 --> @marclaporte commented on GitHub (Aug 21, 2025): > I can try to reproduce problems on your test environment if you like. Super! I will email you later today with credentials and put you in touch with main active devs.
Author
Owner

@marclaporte commented on GitHub (Aug 26, 2025):

For anyone following this thread: @mercihabam, @Shadow243, @Baraka24, @christer77, @kambereBr and I are in touch via email with @ulfgebhardt. The current focus is addressing various issues he found in master on our test site. Many of these are blockers to releasing 2.5.0: https://github.com/cypht-org/cypht/issues/1624

Once 2.5.0 is released, we'll coordinate with @ulfgebhardt on https://github.com/cypht-org/cypht/issues/1354

<!-- gh-comment-id:3226086175 --> @marclaporte commented on GitHub (Aug 26, 2025): For anyone following this thread: @mercihabam, @Shadow243, @Baraka24, @christer77, @kambereBr and I are in touch via email with @ulfgebhardt. The current focus is addressing various issues he found in master on our test site. Many of these are blockers to releasing 2.5.0: https://github.com/cypht-org/cypht/issues/1624 Once 2.5.0 is released, we'll coordinate with @ulfgebhardt on https://github.com/cypht-org/cypht/issues/1354
Author
Owner

@mercihabam commented on GitHub (Aug 30, 2025):

The issue originated from this cherry-picked commit. While it was working fine in master, the page_links output substitution by pages was not needed in 2.4.

<!-- gh-comment-id:3239108960 --> @mercihabam commented on GitHub (Aug 30, 2025): The issue originated from this cherry-picked [commit](https://github.com/cypht-org/cypht/commit/b192975c73fc4576061b00b8c709c901780b3cb3#diff-7e5f70989f0819e6bb212f04f7743d4deac235753f33ad2a85892ef940dfd6c9L219). While it was working fine in master, the `page_links` output substitution by `pages` was not needed in 2.4.
Author
Owner

@mercihabam commented on GitHub (Aug 30, 2025):

Note that 2.4.2 was released immediately after the security fix in that commit, along with one additional commit. This caused the issue to remain invisible in the 2.x branch and only present in that specific release.

Therefore, I am raising a PR to the release-2.4.2 branch, though I am not entirely sure whether we should merge that commit into this branch or if a subsequent 2.4.3 release will be created. Thanks!

<!-- gh-comment-id:3239122518 --> @mercihabam commented on GitHub (Aug 30, 2025): Note that [2.4.2](https://github.com/cypht-org/cypht/releases/tag/v2.4.2) was released immediately after the security fix in that commit, along with one additional commit. This caused the issue to remain invisible in the `2.x` branch and only present in that specific release. Therefore, I am raising a [PR](https://github.com/cypht-org/cypht/pull/1647) to the `release-2.4.2` branch, though I am not entirely sure whether we should merge that commit into this branch or if a subsequent 2.4.3 release will be created. Thanks!
Author
Owner

@marclaporte commented on GitHub (Aug 30, 2025):

@kroky FYI above

<!-- gh-comment-id:3239172410 --> @marclaporte commented on GitHub (Aug 30, 2025): @kroky FYI above
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#678
No description provided.