[GH-ISSUE #1315] DEFAULT_SETTING_TEXT_ONLY's comment & default value are inconsistent #627

Closed
opened 2026-02-25 21:35:32 +03:00 by kerem · 4 comments
Owner

Originally created by @Denperidge on GitHub (Nov 2, 2024).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/1315

Originally assigned to: @Baraka24 on GitHub.

🐛 Bugreport

In the current version of app.php (line 1026), the comment includes "Defaults to false", while the php env default is set to true

Version & Environment

Rev: [abdd8aab42]

Originally created by @Denperidge on GitHub (Nov 2, 2024). Original GitHub issue: https://github.com/cypht-org/cypht/issues/1315 Originally assigned to: @Baraka24 on GitHub. ## 🐛 Bugreport In the [current version of app.php (line 1026)](https://github.com/cypht-org/cypht/blob/abdd8aab4284967bf676a3f8fdbc37c793120f51/config/app.php#L1026), the comment includes "Defaults to false", while the php env default is set to true ### Version & Environment Rev: [abdd8aab4284967bf676a3f8fdbc37c793120f51]
kerem closed this issue 2026-02-25 21:35:32 +03:00
Author
Owner

@marclaporte commented on GitHub (Nov 2, 2024):

@Denperidge Thank you for the reports (this and the other one). I suggest you make merge requests for things like this, and you will be listed as a contributor of Cypht 2.5.0!

<!-- gh-comment-id:2453212651 --> @marclaporte commented on GitHub (Nov 2, 2024): @Denperidge Thank you for the reports (this and the other one). I suggest you make merge requests for things like this, and you will be listed as a contributor of Cypht 2.5.0!
Author
Owner

@Denperidge commented on GitHub (Nov 2, 2024):

@marclaporte Much appreciated! Could you (or someone else with more experience developing Cypht than me) advise on what the correct default value is? (Both for the value in app.php and .env.example? Although with the latter I assume the false value is the correct one)

<!-- gh-comment-id:2453218313 --> @Denperidge commented on GitHub (Nov 2, 2024): @marclaporte Much appreciated! Could you (or someone else with more experience developing Cypht than me) advise on what the correct default value is? (Both for the value in app.php and .env.example? Although with the latter I assume the false value is the correct one)
Author
Owner

@marclaporte commented on GitHub (Nov 14, 2024):

@Denperidge Please confirm in latest master

<!-- gh-comment-id:2475098878 --> @marclaporte commented on GitHub (Nov 14, 2024): @Denperidge Please confirm in latest master
Author
Owner

@Denperidge commented on GitHub (Nov 14, 2024):

Looks perfect! Closing issue 😌

<!-- gh-comment-id:2477069251 --> @Denperidge commented on GitHub (Nov 14, 2024): Looks perfect! Closing issue 😌
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#627
No description provided.