mirror of
https://github.com/cypht-org/cypht.git
synced 2026-04-25 13:05:53 +03:00
[GH-ISSUE #1147] Themes css path incorrect in Tiki-Cypht integration #584
Labels
No labels
2fa
I18N
PGP
Security
Security
account
advanced_search
advanced_search
announcement
api_login
authentication
awaiting feedback
blocker
bug
bug
bug
calendar
config
contacts
core
core
devops
docker
docs
duplicate
dynamic_login
enhancement
epic
feature
feeds
framework
github
github
gmail_contacts
good first issue
help wanted
history
history
imap
imap_folders
inline_message
installation
keyboard_shortcuts
keyboard_shortcuts
ldap_contacts
mobile
need-ssh-access
new module set
nux
pop3
profiles
pull-request
question
refactor
release
research
saved_searches
smtp
strategic
tags
tests
themes
website
wordpress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/cypht#584
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @kroky on GitHub (Aug 6, 2024).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/1147
Originally assigned to: @GedeonTS on GitHub.
The link
return '<link href="' . WEB_ROOT . 'modules/themes/assets/' . $theme_name . '/css/' . $theme_name . '.css?v=' . CACHE_ID . '" media="all" rel="stylesheet" type="text/css" />';in themes/modules work in standalone cypht but not in Tiki-Cypht integration. I think we should change the way this is inserted/requested and do it through config_gen file much like site.css, etc. are generated and included. Then, Tiki-Cypht integration will be able to use the correct path to include the file.@marclaporte commented on GitHub (Aug 6, 2024):
Also about paths: https://gitlab.com/tikiwiki/tiki/-/merge_requests/5483
@GedeonTS commented on GitHub (Aug 21, 2024):
Fixed by @Shadow243 in https://github.com/cypht-org/cypht/pull/1185