[GH-ISSUE #1147] Themes css path incorrect in Tiki-Cypht integration #584

Closed
opened 2026-02-25 21:35:25 +03:00 by kerem · 2 comments
Owner

Originally created by @kroky on GitHub (Aug 6, 2024).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/1147

Originally assigned to: @GedeonTS on GitHub.

The link return '<link href="' . WEB_ROOT . 'modules/themes/assets/' . $theme_name . '/css/' . $theme_name . '.css?v=' . CACHE_ID . '" media="all" rel="stylesheet" type="text/css" />'; in themes/modules work in standalone cypht but not in Tiki-Cypht integration. I think we should change the way this is inserted/requested and do it through config_gen file much like site.css, etc. are generated and included. Then, Tiki-Cypht integration will be able to use the correct path to include the file.

Originally created by @kroky on GitHub (Aug 6, 2024). Original GitHub issue: https://github.com/cypht-org/cypht/issues/1147 Originally assigned to: @GedeonTS on GitHub. The link `return '<link href="' . WEB_ROOT . 'modules/themes/assets/' . $theme_name . '/css/' . $theme_name . '.css?v=' . CACHE_ID . '" media="all" rel="stylesheet" type="text/css" />';` in themes/modules work in standalone cypht but not in Tiki-Cypht integration. I think we should change the way this is inserted/requested and do it through config_gen file much like site.css, etc. are generated and included. Then, Tiki-Cypht integration will be able to use the correct path to include the file.
kerem closed this issue 2026-02-25 21:35:25 +03:00
Author
Owner

@marclaporte commented on GitHub (Aug 6, 2024):

Also about paths: https://gitlab.com/tikiwiki/tiki/-/merge_requests/5483

<!-- gh-comment-id:2272171741 --> @marclaporte commented on GitHub (Aug 6, 2024): Also about paths: https://gitlab.com/tikiwiki/tiki/-/merge_requests/5483
Author
Owner

@GedeonTS commented on GitHub (Aug 21, 2024):

Fixed by @Shadow243 in https://github.com/cypht-org/cypht/pull/1185

<!-- gh-comment-id:2302955401 --> @GedeonTS commented on GitHub (Aug 21, 2024): Fixed by @Shadow243 in https://github.com/cypht-org/cypht/pull/1185
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/cypht#584
No description provided.