mirror of
https://github.com/cypht-org/cypht.git
synced 2026-04-25 13:05:53 +03:00
[GH-ISSUE #962] Hm, TM - what are these in reference to? #520
Labels
No labels
2fa
I18N
PGP
Security
Security
account
advanced_search
advanced_search
announcement
api_login
authentication
awaiting feedback
blocker
bug
bug
bug
calendar
config
contacts
core
core
devops
docker
docs
duplicate
dynamic_login
enhancement
epic
feature
feeds
framework
github
github
gmail_contacts
good first issue
help wanted
history
history
imap
imap_folders
inline_message
installation
keyboard_shortcuts
keyboard_shortcuts
ldap_contacts
mobile
need-ssh-access
new module set
nux
pop3
profiles
pull-request
question
refactor
release
research
saved_searches
smtp
strategic
tags
tests
themes
website
wordpress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/cypht#520
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @TheDigitalOrchard on GitHub (Apr 18, 2024).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/962
💬 Question
Throughout the Cypht framework, there are classes prefixed with
Hm_, and the Environment variables are stored with a prefix ofTM_.What are these in reference to? Legacy name? If so, can we deprecate these in favour of a
Cypht_ \ CYPHT_prefix?@marclaporte commented on GitHub (Apr 18, 2024):
Context: https://github.com/cypht-org/cypht/issues/602
Yes, we should clean up!
If low risk, we sneak in 2.0, else 2.1 or 3.0
@marclaporte commented on GitHub (Apr 18, 2024):
@Shadow243 As you worked on https://github.com/cypht-org/cypht/pull/823/ please opine.
@Shadow243 commented on GitHub (Apr 18, 2024):
This is an option to take into consideration, however there is too much refactoring to do because this will affect all cypht modules, unit tests, lib and certain javascript files.
I would therefore suggest doing this in a version other than 2.0 which must already be released asap.
@marclaporte commented on GitHub (Apr 18, 2024):
@Shadow243 what does TM stand for?
@Shadow243 commented on GitHub (Apr 18, 2024):
The idea of putting dotenv came from tiki manager, this TM surely came from there too (TIKI MANAGER) and so I didn't change it by putting something else, it could be CYPHT_
@marclaporte commented on GitHub (Apr 18, 2024):
Is this for
Hm_,TM_or both?Cypht 2.0 has not been released yet so almost no one is using TM_ yet. So it could make sense to do before we release 2.0: https://github.com/cypht-org/cypht/issues/966
@Shadow243 commented on GitHub (Apr 18, 2024):
Copy that @marclaporte
@marclaporte commented on GitHub (Apr 18, 2024):
https://github.com/cypht-org/cypht/pull/967
@marclaporte commented on GitHub (May 6, 2024):
So this task is partly done, and the rest is covered by https://github.com/cypht-org/cypht/issues/602