starred/cypht

Fork 0

mirror of https://github.com/cypht-org/cypht.git synced 2026-04-26 05:26:00 +03:00

[GH-ISSUE #882] A "remark" field to remember why you added a profile #510

New issue

Closed

opened 2026-02-25 21:35:12 +03:00 by kerem · 14 comments

kerem commented

2026-02-25 21:35:12 +03:00

Owner

Originally created by @w-b-k on GitHub (Feb 5, 2024).
Original GitHub issue: https://github.com/cypht-org/cypht/issues/882

Originally assigned to: @IrAlfred on GitHub.

🗣 Suggestion

I create a mail alias and a corresponding identity/profile per organization/entity/contact that I deal with, to isolate data leaks and prevent merging of profiles in different providers' back-ends.
The aliases are not very self-explanatory, so I keep notes which alias goes with which entity.

For me it would be helpful to have a "remarks" field in addition to the "signature" field when managing profiles. Is it too much a niche application of aliases/profiles to have any merit outside of my application, or would it be something useful for a wider audience?

Thank you for your consideration!

Originally created by @w-b-k on GitHub (Feb 5, 2024). Original GitHub issue: https://github.com/cypht-org/cypht/issues/882 Originally assigned to: @IrAlfred on GitHub. ## 🗣 Suggestion  I create a mail alias and a corresponding identity/profile per organization/entity/contact that I deal with, to isolate data leaks and prevent merging of profiles in different providers' back-ends. The aliases are not very self-explanatory, so I keep notes which alias goes with which entity. For me it would be helpful to have a "remarks" field in addition to the "signature" field when managing profiles. Is it too much a niche application of aliases/profiles to have any merit outside of my application, or would it be something useful for a wider audience? Thank you for your consideration!

kerem closed this issue

2026-02-25 21:35:12 +03:00

kerem commented

2026-02-25 21:35:13 +03:00

Author

Owner

@marclaporte commented on GitHub (Feb 5, 2024):

@w-b-k I Iike it. Let's do it.

@marclaporte commented on GitHub (Feb 5, 2024): @w-b-k I Iike it. Let's do it.

kerem commented

2026-02-25 21:35:13 +03:00

Author

Owner

@marclaporte commented on GitHub (Feb 5, 2024):

@IrAlfred Please show us your skills :-)

@marclaporte commented on GitHub (Feb 5, 2024): @IrAlfred Please show us your skills :-)

kerem commented

2026-02-25 21:35:13 +03:00

Author

Owner

@marclaporte commented on GitHub (Feb 6, 2024):

@w-b-k: looking at this more:

There are two text fields:

Display Name
Signature

What would be negative about using the Display Name?

@marclaporte commented on GitHub (Feb 6, 2024): @w-b-k: looking at this more: There are two text fields: * Display Name * Signature What would be negative about using the Display Name?

kerem commented

2026-02-25 21:35:13 +03:00

Author

Owner

@IrAlfred commented on GitHub (Feb 6, 2024):

@IrAlfred Please show us your skills :-)

Not sure to understand well what this is about, please I need more details

@IrAlfred commented on GitHub (Feb 6, 2024): > @IrAlfred Please show us your skills :-) Not sure to understand well what this is about, please I need more details

kerem commented

2026-02-25 21:35:13 +03:00

Author

Owner

@w-b-k commented on GitHub (Feb 6, 2024):

Hi, thanks for your prompt response ! :-)

What would be negative about using the Display Name?

Is the display name not the field that is sent as "My Name" to the recipient of the email?

I would write something like "added this alias for exchange with the piano teacher; starting 20240103". If "Display name" is not sent as "My Name" with the email, is another field used to supply the recipient with my name?

@w-b-k commented on GitHub (Feb 6, 2024): Hi, thanks for your prompt response ! :-) > What would be negative about using the Display Name? Is the display name not the field that is sent as "My Name" to the recipient of the email? I would write something like "added this alias for exchange with the piano teacher; starting 20240103". If "Display name" is not sent as "My Name" with the email, is another field used to supply the recipient with my name?

kerem commented

2026-02-25 21:35:13 +03:00

Author

Owner

@marclaporte commented on GitHub (Feb 6, 2024):

@w-b-k Good point. Please test, and if Display Name is used as you said, we'll add one more field.

@marclaporte commented on GitHub (Feb 6, 2024): @w-b-k Good point. Please test, and if Display Name is used as you said, we'll add one more field.

kerem commented

2026-02-25 21:35:13 +03:00

Author

Owner

@marclaporte commented on GitHub (Feb 6, 2024):

@IrAlfred https://github.com/cypht-org/cypht/tree/master/modules/profiles

@marclaporte commented on GitHub (Feb 6, 2024): @IrAlfred https://github.com/cypht-org/cypht/tree/master/modules/profiles

kerem commented

2026-02-25 21:35:13 +03:00

Author

Owner

@w-b-k commented on GitHub (Feb 8, 2024):

@w-b-k Good point. Please test, and if Display Name is used as you said, we'll add one more field.

Tested. The text entered in the "Display name" field is displayed in Cypht when sending a new message (below the field for typing the message, a combobox to select the from-identity).

In the receiving mail client, the text is displayed as the 'friendly name' in combination with the email address.

@IrAlfred Please show us your skills :-)

Not sure to understand well what this is about, please I need more details

I got there by cilcking Profiles under Settings:

When adding (or editing) a profile, the confusion was about the "Display name" field:

I'd like to have an option to write some remarks about why I added the particular profile:

(In a perfect world the field would be multi line, or a wider letter box :-P )

@w-b-k commented on GitHub (Feb 8, 2024): > @w-b-k Good point. Please test, and if Display Name is used as you said, we'll add one more field. Tested. The text entered in the "Display name" field is displayed in Cypht when sending a new message (below the field for typing the message, a combobox to select the from-identity). In the receiving mail client, the text is displayed as the 'friendly name' in combination with the email address. > > @IrAlfred Please show us your skills :-) > > Not sure to understand well what this is about, please I need more details I got there by cilcking Profiles under Settings: ![image](https://github.com/cypht-org/cypht/assets/27885942/89916d64-50fc-4cf1-8a57-7664f4282ae1) When adding (or editing) a profile, the confusion was about the "Display name" field: ![image](https://github.com/cypht-org/cypht/assets/27885942/e8576614-64f4-4056-a705-4e0b07d32aa6) I'd like to have an option to write some remarks about why I added the particular profile: ![image](https://github.com/cypht-org/cypht/assets/27885942/236b090e-0279-4643-84c8-50d3afc29428) (In a perfect world the field would be multi line, or a wider letter box :-P )

kerem commented

2026-02-25 21:35:13 +03:00

Author

Owner

@IrAlfred commented on GitHub (Feb 12, 2024):

Okay, thanks

@IrAlfred commented on GitHub (Feb 12, 2024): Okay, thanks

kerem commented

2026-02-25 21:35:13 +03:00

Author

Owner

@marclaporte commented on GitHub (Feb 17, 2024):

@w-b-k Can you please test? https://github.com/cypht-org/cypht/pull/903

@marclaporte commented on GitHub (Feb 17, 2024): @w-b-k Can you please test? https://github.com/cypht-org/cypht/pull/903

kerem commented

2026-02-25 21:35:13 +03:00

Author

Owner

@w-b-k commented on GitHub (Feb 17, 2024):

Hi Alfred & Marc,

Thank you, looks (and works, on first test) great!

A small non-functional remark on the changes in modules.php : in most places the rmk is added after sig, but in a cases it is added on a different position, for example on line 129 it follows 'type', instead of 'sig' (at line 121). Is that on purpose?

Edit: on second, more general test:

Setting/retrieving a remark with a profile works (new with this change)
Setting/retrieving a signature works (is not new)
A signature is not added to outgoing mail (is not as expected)

I'm not a heavy user of preconfigured signatures. I am not sure whether it used to work, or that the not-working is specific to my installation: I noticed the new files being quite different from the ones I had installed (1.4.1, via Yunohost; what is the current version?)

@w-b-k commented on GitHub (Feb 17, 2024): Hi Alfred & Marc, Thank you, looks (and works, on first test) great! A small non-functional remark on the changes in modules.php : in most places the rmk is added after sig, but in a cases it is added on a different position, for example on [line 129](https://github.com/cypht-org/cypht/pull/903/files#diff-2375a5d259659c96bfacd4c4e717655616a0e7afe58f398934baec685572cc1fR129) it follows 'type', instead of 'sig' (at line 121). Is that on purpose? Edit: on second, more general test: * Setting/retrieving a remark with a profile works (new with this change) * Setting/retrieving a signature works (is not new) * A signature is not added to outgoing mail (is not as expected) I'm not a heavy user of preconfigured signatures. I am not sure whether it used to work, or that the not-working is specific to my installation: I noticed the new files being quite different from the ones I had installed (1.4.1, via Yunohost; what is the current version?)

kerem commented

2026-02-25 21:35:13 +03:00

Author

Owner

@IrAlfred commented on GitHub (Feb 18, 2024):

Thank you for your feedback. Regarding the non-functional remark concerning the position of rmk in the module.php file compared to its position in other places, this was not done on purpose but just that we didn't pay too much attention to it . I fix that for good harmony.

@IrAlfred commented on GitHub (Feb 18, 2024): Thank you for your feedback. Regarding the non-functional remark concerning the position of rmk in the module.php file compared to its position in other places, this was not done on purpose but just that we didn't pay too much attention to it . I fix that for good harmony.

kerem commented

2026-02-25 21:35:13 +03:00

Author

Owner

@marclaporte commented on GitHub (Feb 18, 2024):

I noticed the new files being quite different from the ones I had installed (1.4.1, via Yunohost; what is the current version?)

Cypht 1.4.1 is the current stable version. Because of major changes in master, the next release will be 2.0

@marclaporte commented on GitHub (Feb 18, 2024): > I noticed the new files being quite different from the ones I had installed (1.4.1, via Yunohost; what is the current version?) Cypht 1.4.1 is the current stable version. Because of major changes in master, the next release will be 2.0

kerem commented

2026-02-25 21:35:13 +03:00

Author

Owner

@marclaporte commented on GitHub (Feb 24, 2024):

@w-b-k Is the latest code good to merge?

@marclaporte commented on GitHub (Feb 24, 2024): @w-b-k Is the latest code good to merge?

kerem referenced this issue

2026-02-25 21:36:27 +03:00

[PR #510] [MERGED] fix of the overflow of array elements containing profile information. #860